Skip to content

Conversation

pront
Copy link
Member

@pront pront commented Aug 4, 2025

Summary

Apart from the obvious update, it downgrades cargo-deb to 2.9.1.

I discovered that the cargo-deb used by packaging is actually the one in the Vector Docker image. Something to improve in the future.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Ref: kornelski/cargo-deb#183

Ref: migration log
2024_migration.txt

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: sinks Anything related to the Vector's sinks domain: codecs Anything related to Vector's codecs (encoding/decoding) labels Aug 4, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Aug 4, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5d7d20e | Docs | Was this helpful? Give us feedback!

@pront pront force-pushed the pront-rust-2024 branch from cb3db8e to d20b90a Compare August 5, 2025 15:55
@github-actions github-actions bot removed the domain: codecs Anything related to Vector's codecs (encoding/decoding) label Aug 5, 2025
@github-actions github-actions bot added domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components domain: codecs Anything related to Vector's codecs (encoding/decoding) labels Aug 5, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 5, 2025
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes also needed to .rustfmt.toml I think

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Aug 13, 2025
@github-actions github-actions bot removed the domain: ci Anything related to Vector's CI environment label Aug 18, 2025
@pront pront enabled auto-merge August 18, 2025 21:11
@github-actions github-actions bot added domain: ci Anything related to Vector's CI environment domain: releasing Anything related to releasing Vector labels Aug 19, 2025
@pront pront added this pull request to the merge queue Aug 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2025
@pront pront enabled auto-merge August 19, 2025 16:53
@pront pront added this pull request to the merge queue Aug 19, 2025
Merged via the queue into master with commit fffcea5 Aug 19, 2025
87 checks passed
@pront pront deleted the pront-rust-2024 branch August 19, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: releasing Anything related to releasing Vector domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants