Skip to content

fix(dev): update test config#23529

Merged
pront merged 1 commit intomasterfrom
pront-fix-test
Aug 6, 2025
Merged

fix(dev): update test config#23529
pront merged 1 commit intomasterfrom
pront-fix-test

Conversation

@pront
Copy link
Member

@pront pront commented Aug 5, 2025

Summary

Vector configuration

How did you test this PR?

cargo clippy --all-targets --all-features

This is a make check-clippy blind spot.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront requested a review from a team as a code owner August 5, 2025 21:19
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 5, 2025
@pront pront enabled auto-merge August 5, 2025 21:19
@pront pront requested a review from thomasqueirozb August 5, 2025 21:20
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in our CI needs to be updated so this stuff doesn't sneak in. Thanks!

@pront pront added this pull request to the merge queue Aug 6, 2025
@pront
Copy link
Member Author

pront commented Aug 6, 2025

Something in our CI needs to be updated so this stuff doesn't sneak in. Thanks!

I discovered it with

cargo clippy --all-targets --all-features

Not sure what vdev is doing for this, but we can potentially just make it run the above.

Merged via the queue into master with commit 1d646da Aug 6, 2025
112 of 113 checks passed
@pront pront deleted the pront-fix-test branch August 6, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants