Skip to content

fix(ci): fail when jobs are cancelled#23545

Merged
thomasqueirozb merged 1 commit intomasterfrom
ci-failed-when-cancelled
Aug 7, 2025
Merged

fix(ci): fail when jobs are cancelled#23545
thomasqueirozb merged 1 commit intomasterfrom
ci-failed-when-cancelled

Conversation

@thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Aug 6, 2025

Summary

This standardizes the last step in many workflows that were only checking for failure and missed the check for cancelled

Vector configuration

NA

How did you test this PR?

/ci-run-all

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

This standardizes the last step in many workflows that were only checking for failure and missed the
check for cancelled
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner August 6, 2025 21:23
@thomasqueirozb thomasqueirozb added the domain: ci Anything related to Vector's CI environment label Aug 6, 2025
@thomasqueirozb thomasqueirozb requested a review from a team as a code owner August 6, 2025 21:23
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 6, 2025
@github-actions github-actions bot removed the domain: ci Anything related to Vector's CI environment label Aug 6, 2025
Copy link
Contributor Author

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-all

@thomasqueirozb thomasqueirozb added this pull request to the merge queue Aug 7, 2025
Merged via the queue into master with commit 317f151 Aug 7, 2025
234 of 239 checks passed
@thomasqueirozb thomasqueirozb deleted the ci-failed-when-cancelled branch August 7, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants