feat(new source):Initial addition of GCS support #23916
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: sources
pront
reviewed
Oct 2, 2025
| counter!("gcp_cloud_storage_objects_filtered_total") | ||
| .increment(1); | ||
| } | ||
| } |
Comment on lines
+202
to
+203
| // #[cfg(feature = "sources-gcp_cloud_storage")] | ||
| // pub(crate) use self::gcp_cloud_storage::*; |
There was a problem hiding this comment.
Suggested change
| // #[cfg(feature = "sources-gcp_cloud_storage")] | |
| // pub(crate) use self::gcp_cloud_storage::*; |
| /// Automatically attempt to determine the compression scheme. | ||
| /// | ||
| /// The compression scheme of the object is determined from its `Content-Encoding` and | ||
| /// `Content-Type` metadata, as well as the key suffix (for example, `.gz`). |
There was a problem hiding this comment.
as well as the key suffix
let's explain a bit more what has precedence to avoid user confusion
src/sources/gcp_cloud_storage/mod.rs
Outdated
Comment on lines
113
to
121
| #[configurable(derived)] | ||
| #[serde(default = "default_framing")] | ||
| #[derivative(Default(value = "default_framing()"))] | ||
| pub framing: FramingConfig, | ||
|
|
||
| #[configurable(derived)] | ||
| #[serde(default = "default_decoding")] | ||
| #[derivative(Default(value = "default_decoding()"))] | ||
| pub decoding: DeserializerConfig, |
There was a problem hiding this comment.
Nit:
Suggested change
| #[configurable(derived)] | |
| #[serde(default = "default_framing")] | |
| #[derivative(Default(value = "default_framing()"))] | |
| pub framing: FramingConfig, | |
| #[configurable(derived)] | |
| #[serde(default = "default_decoding")] | |
| #[derivative(Default(value = "default_decoding()"))] | |
| pub decoding: DeserializerConfig, | |
| #[serde(flatten)] | |
| pub encoding: EncodingConfigWithFraming, |
There was a problem hiding this comment.
Isnt this strictly for sinks?
Co-authored-by: Pavlos Rontidis <[email protected]>
|
Just a note, ill be on leave for a little while, but will come back to this. I have a few of the suggestions implemented & cleaning up the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT WHILE IN PROGRESS
Summary
This adds GCS as a source. It is built primarily off of the AWS S3 source concept (replacing SQS with pubsub, and S3 with GCS).
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Closes: #7501
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.