chore(vdev): clean up clippy some allow statements

vdev/src/commands/complete.rs

@@ -14,6 +14,7 @@ pub struct Cli {
 }
 
 impl Cli {
+    #[allow(clippy::unnecessary_wraps)]
     pub fn exec(self) -> Result<()> {
         let mut cmd = RootCli::command();
         let bin_name = cmd.get_name().to_string();

vdev/src/commands/info.rs

@@ -10,6 +10,7 @@ use crate::{app, config, platform};
 pub struct Cli {}
 
 impl Cli {
+    #[allow(clippy::unnecessary_wraps)]
     pub fn exec(self) -> Result<()> {
         println!("Container tool:  {}", CONTAINER_TOOL.display());
         println!("Data path:       {}", platform::data_dir().display());

vdev/src/commands/meta/starship.rs

@@ -9,6 +9,7 @@ use crate::util::CargoToml;
 pub struct Cli {}
 
 impl Cli {
+    #[allow(clippy::unnecessary_wraps)]
     pub fn exec(self) -> Result<()> {
         let mut contexts = vec![];
 

vdev/src/commands/mod.rs

@@ -1,3 +1,12 @@
+#![allow(
+    // allows print! and println! in this module for commands to output to terminal
+    clippy::print_stdout,
+
+    // The cli_commands! macro generates exec() methods for all commands. Some commands
+    // use self while others don't, so we allow unused_self to avoid false warnings.
+    clippy::unused_self,
+)]
+
 use clap::Parser;
 use clap_verbosity_flag::{InfoLevel, Verbosity};
 

vdev/src/commands/release/channel.rs

@@ -11,6 +11,7 @@ use crate::util::get_channel;
 pub struct Cli {}
 
 impl Cli {
+    #[allow(clippy::unnecessary_wraps)]
     pub fn exec(self) -> Result<()> {
         let channel = get_channel();
 

vdev/src/commands/test.rs

@@ -35,7 +35,7 @@ fn parse_env(env: Vec<String>) -> BTreeMap<String, Option<String>> {
 
 impl Cli {
     pub fn exec(self) -> Result<()> {
-        let runner = get_agent_test_runner(self.container)?;
+        let runner = get_agent_test_runner(self.container);
 
         let mut args = vec!["--workspace".to_string()];
 

vdev/src/main.rs

@@ -1,10 +1,4 @@
 #![deny(clippy::pedantic, warnings)]
-#![allow(
-    clippy::module_name_repetitions,
-    clippy::print_stdout,
-    clippy::unused_self,
-    clippy::unnecessary_wraps
-)]
 
 #[macro_use]
 mod macros;

vdev/src/testing/integration.rs

@@ -103,7 +103,7 @@ impl ComposeTest {
             runner_name,
             &config.runner,
             compose.is_some().then_some(network_name),
-        )?;
+        );
 
         env_config.insert("VECTOR_IMAGE".to_string(), Some(runner.image_name()));
 

vdev/src/testing/runner.rs

@@ -39,11 +39,11 @@ pub enum RunnerState {
     Unknown,
 }
 
-pub fn get_agent_test_runner(container: bool) -> Result<Box<dyn TestRunner>> {
+pub fn get_agent_test_runner(container: bool) -> Box<dyn TestRunner> {
     if container {
-        Ok(Box::new(DockerTestRunner))
+        Box::new(DockerTestRunner)
     } else {
-        Ok(Box::new(LocalTestRunner))
+        Box::new(LocalTestRunner)
     }
 }
 
@@ -274,7 +274,7 @@ impl IntegrationTestRunner {
         integration: Option<String>,
         config: &IntegrationRunnerConfig,
         network: Option<String>,
-    ) -> Result<Self> {
+    ) -> Self {
         let mut volumes: Vec<String> = config
             .volumes
             .iter()
@@ -283,12 +283,12 @@ impl IntegrationTestRunner {
 
         volumes.push(format!("{VOLUME_TARGET}:/output"));
 
-        Ok(Self {
+        Self {
             integration,
             needs_docker_socket: config.needs_docker_socket,
             network,
             volumes,
-        })
+        }
     }
 
     pub(super) fn ensure_network(&self) -> Result<()> {