-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(sources): collect headers for logs in opentelemetry source with use_otlp_decoding set to true #24307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sources): collect headers for logs in opentelemetry source with use_otlp_decoding set to true #24307
Conversation
…ith/without use_otlp_decoding
|
All contributors have signed the CLA ✍️ ✅ |
…telemetry-source-headers
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
…telemetry-source-headers
…telemetry-source-headers
…telemetry-source-headers
…telemetry-source-headers
…telemetry-source-headers
…telemetry-source-headers
…telemetry-source-headers
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ozanichkovsky (FYI I just happened to see this, I am on a leave so ping the Vector team instead to drive this forward)
…telemetry-source-headers
|
Thanks @pront. I don't know for sure if there is a way to properly tag Vector team, so I'm tagging @thomasqueirozb and |
…telemetry-source-headers
|
Maybe I can also tag @jszwedko |
…telemetry-source-headers
|
Hey @ozanichkovsky, pinging |
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense. Thanks for your contribution!
Head branch was pushed to by a user without write access
|
@thomasqueirozb I updated the changelog to actually say that it is for logs only. I tried to implement this for all event types first, but it would rather be a new feature implementation, not a bug fix. |
|
@vectordotdev/vector should be ready to pass all the checks. |
|
@thomasqueirozb I unfortunately can't run all checks, so merging is still blocked until something is done by the vector team. |
Summary
This PR expands the existing header-enrichment logic in the opentelemetry source so that headers are applied consistently to logs across both decoding modes (use_otlp_decoding enabled or disabled).
What the PR Does
Ensures headers are also applied when use_otlp_decoding: true, where enrichment was previously skipped entirely.
Verification
The changes were tested using a custom local build derived from this PR, confirming that headers are now correctly attached to logs (both decode modes).
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Closes: #24306
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.