-
Notifications
You must be signed in to change notification settings - Fork 2k
enhancement(clickhouse sink): Add ArrowStream format
#24373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(clickhouse sink): Add ArrowStream format
#24373
Conversation
c0ef89f to
67750ba
Compare
67750ba to
42c4fb5
Compare
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments here are regarding improvements. This is very nice work and should work as is, thanks a lot!
e678a00 to
db3297d
Compare
db3297d to
9e93926
Compare
6eb8efc to
de463ec
Compare
de463ec to
834ce89
Compare
Per the docs; this is a limitation of the Arrow format: So it's not fully backwards compatible with the JSON encoder. Would make sense to call this out in the documentation. |
32578f1 to
4710668
Compare
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only a couple of small nits and small improvements but this should be pretty much good to go!
Head branch was pushed to by a user without write access
Summary
This PR adds support for the
ArrowStreamformat to Clickhouse.Vector configuration
How did you test this PR?
Ran against local Clickhouse instance, integration tests
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.