feat(new source): add parse_yaml function
#1602
Open
+174
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `parse_yaml` function as per discussion in vectordotdev#1601. - New feature - No breaking change Sibling doc PR: vectordotdev/vector#24479 Tested with: ``` ./scripts/checks.sh ```
Comment on lines
+1
to
+5
| //use serde_yaml::{ | ||
| // //Error, | ||
| // //value::{Value as YamlValue}, | ||
| //}; | ||
|
|
Contributor
There was a problem hiding this comment.
We can remove this
Suggested change
| //use serde_yaml::{ | |
| // //Error, | |
| // //value::{Value as YamlValue}, | |
| //}; |
| }] | ||
| } | ||
|
|
||
| fn examples(&self) -> &'static [Example] { |
Contributor
There was a problem hiding this comment.
These examples are fine but they're missing an actual yaml like you'd expect to see. Something like what you did in the complex_yaml test would be nice to have here
Author
There was a problem hiding this comment.
I struggled with a raw string inside another since rust is not my primary programming language. What's the best way to do it without the compiler complaining about the extra hashes?
| seahash = { version = "4", optional = true } | ||
| serde = { version = "1", features = ["derive"], optional = true } | ||
| serde_json = { version = "1", default-features = false, optional = true, features = ["std", "raw_value"] } | ||
| serde_yaml = { version = "0.9.34" } |
Contributor
There was a problem hiding this comment.
This library is now unmaintained. I think we should use either serde_yaml_ng or serde_norway instead. I haven't looked too deeply into them to know which one is better maintained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
parse_yamlfunction as per discussion in #1601.Sibling doc PR: vectordotdev/vector#24479
Tested with: