fix(typescript-client): Add error handling to all API methods #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, most methods in HindsightClient would silently return undefined when API calls failed (e.g., connection refused). Only the `recall` method had proper error checking. This change adds a `validateResponse` helper method and applies it consistently to all API methods: - retain - retainBatch - recall - reflect - listMemories - createBank - getBankProfile Now all methods properly throw an error with details when the API request fails, instead of returning undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
validateResponsehelper method that checks for API errorsresponse.data!without validationProblem
Most methods in the TypeScript client were returning
response.data!without checking if the response was successful. When the API was unreachable or returned an error, these methods would silently returnundefinedinstead of throwing an error.This was discovered when running load tests against a non-existent server - the tests showed 100% success rate because
retainandreflectnever threw errors.Changes
Methods updated:
retainretainBatchrecall(already had error checking, now uses the shared helper)reflectlistMemoriescreateBankgetBankProfileTest plan
npm test)npm run build)