Draft
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Converts `SIGNAL`/`SLOT` macro usage to type-safe pointer-to-member syntax, enhancing compile-time error detection and code robustness. Transitions QML type registration to use the `QML_ELEMENT` macro and `qt_add_qml_module` in CMake. This streamlines QML imports by providing all types under a single module (`Vedder.vesc`) and removes numerous manual `qmlRegisterType` calls. Removes explicit `qRegisterMetaType` calls, leveraging automatic metatype registration available in modern Qt. Updates `foreach` loops to range-based for loops for improved code readability. Ensures the correct `BleUart` or `BleUartDummy` implementation is included based on the build's Bluetooth support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept migration to Qt6.11 and Cmake (preferred build system for Qt6)
I'm not sure what the current sentiment is around moving to Qt6 given licensing structure but I thought I'd make this PR to show the feasibility. And I would also like to contribute in the future but most of the newer interesting stuff requires Qt6. For instance we can do away with all the fragile nested QEventloops we currently have and replace them with QtTaskTree
Please let me know if there are major reasons not to move to Qt6. If there are none I will spend more time on this to make this proper.