-
Notifications
You must be signed in to change notification settings - Fork 214
Added back CommonsJS output under /cjs #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c077e49
initial config
arthurfiorette f877ec4
fix: lint
arthurfiorette 1292823
fix
arthurfiorette a7c86f2
fixed esm/cjs fuckery
arthurfiorette d3069c8
fix: removed unused comment
arthurfiorette 89f0b4a
feat: importHelpers for esm
arthurfiorette ac31feb
Merge branch 'next' into cjs-output
arthurfiorette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Having the same source code to work with Node16's ESM and Node's CJS is a pain. | ||
// this script simply copies the packageJson version inside the main ts-json-schema-generator.js file | ||
|
||
import fs from "node:fs"; | ||
import path from "node:path"; | ||
import pkg from "../package.json" with { type: "json" }; | ||
|
||
function replaceVersion(source, version) { | ||
return source.replace(/const pkgVersion = "0.0.0";/, `const pkgVersion = "${version}";`); | ||
} | ||
|
||
function replaceFile(path) { | ||
const source = fs.readFileSync(path, "utf-8"); | ||
fs.writeFileSync(path, replaceVersion(source, pkg.version)); | ||
} | ||
|
||
replaceFile(path.resolve("cjs/ts-json-schema-generator.js")); | ||
replaceFile(path.resolve("dist/ts-json-schema-generator.js")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
"compilerOptions": { | ||
"target": "ES2022", | ||
"module": "CommonJS", | ||
"moduleResolution": "Node", | ||
"outDir": "cjs" | ||
}, | ||
"files": ["ts-json-schema-generator.ts", "index.ts"], | ||
"include": ["src/**/*.ts", "factory/**/*.ts"], | ||
"exclude": ["node_modules", "dist", "cjs"] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.