Upgraded to Typescript@3.6, Vega@5.2, Vega-Lite@3.4, Webpack@4.1 by siyaoL1 · Pull Request #886 · vega/voyager

siyaoL1 · 2022-04-06T19:43:28Z

List of upgraded dependencies:

ajv
vega
vega-lite
compassql
vega-datasets
vega-expression
vega-tooltip
vega-typings
vega-util
vega-functions
css-loader
extract-text-webpack-plugin
file-loader
html-webpack-plugin
postcss-loader
react-dnd
react-dev-utils
react-hot-loader
sass-loader
source-map-loader
terser-webpack-plugin
ts-jest
ts-loader
typescript
url-loader
webpack
webpack-cli
webpack-dev-server
webpack-manifest-plugin
@types/webpack
@types/node
@types/react

Needed to remove a line in the PlotBase definition due to the upgrade of @types/react Have to change protected to public for componentWillUnmount() function

Merged the upgrades from upgrade_webpack branch with typescript 3.4.1

yarn built successfully, and passes all the tests. However the webpack-dev-server renders a blank screen which still need to be solved.

Co-authored-by: Dominik Moritz <domoritz@gmail.com>

And resolved the style issue.

siyaoL1 · 2022-04-07T21:11:18Z

I will work on addressing the comments

However, there still are errors when running jest

lgtm-com · 2022-04-20T19:57:01Z

This pull request introduces 3 alerts when merging 8822adf into 882809f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Unreachable statement

lgtm-com · 2022-04-26T23:22:11Z

This pull request introduces 2 alerts when merging d86b3e7 into 882809f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2022-04-26T23:44:52Z

This pull request introduces 2 alerts when merging 40bec63 into 882809f - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

domoritz · 2022-04-29T19:16:01Z

Please fix the tests

Still working on resolving UI Jest test errors

lgtm-com · 2022-05-25T21:00:29Z

This pull request introduces 2 alerts when merging 6d04f84 into 2bd9d86 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

domoritz · 2022-05-27T01:38:57Z

Let me know when tests pass.

domoritz

Very nice!

Please remove yarn-error.log.

Did you check that the app works as expected? If so, I will make a final pass and merge after you address my comments.

domoritz · 2022-05-31T18:06:09Z

config/webpack.config.lib.js

 var WebpackNotifierPlugin = require('webpack-notifier');

-const getClientEnvironment = require('./env');
+// const getClientEnvironment = require('./env');


please remove commented out code

domoritz · 2022-05-31T18:06:15Z

config/webpack.config.lib.js

-var publicUrl = '';
-const env = getClientEnvironment(publicUrl);
+// var publicUrl = '';
+// const env = getClientEnvironment(publicUrl);


same as above

siyaoL1 · 2022-06-01T03:06:58Z

Thanks! I just addressed the comments and deleted the unavailable datasets, and I have tested that the app works as expected. Would you like me to add more datasets from vega-datasets?

domoritz · 2022-06-05T16:23:02Z

@siyaoL1 is working on support CSV and then we can merge this.

Now the default dataset supports csv files from vega_datasets, such as birdstricks.csv.

lgtm-com · 2022-06-08T05:37:15Z

This pull request introduces 1 alert when merging 0bd2706 into 2bd9d86 - view on LGTM.com

new alerts:

1 for Incomplete multi-character sanitization

siyaoL1 and others added 30 commits July 11, 2021 20:58

Fixed three errors for typescript upgrade

43da3ae

fixed issue for lint test

9e87f8f

added webpack 3.4.1 upgrade

0f63364

minor modification for @types/react version

5a6db91

Fixed @types/react error

9c71a1d

Needed to remove a line in the PlotBase definition due to the upgrade of @types/react Have to change protected to public for componentWillUnmount() function

Merge branch 'master' into upgrade_typescript

4356b69

Update yarn.lock

03c544b

Merged webpack4.0.0 upgrade from upgrade_webpack branch

692e5c8

Merged the upgrades from upgrade_webpack branch with typescript 3.4.1

Upgraded css-loader and some @type packages

f03aed8

error fixing for upgrading

c950dd7

Finished upgrading webpack to 4.0.0

d766507

yarn built successfully, and passes all the tests. However the webpack-dev-server renders a blank screen which still need to be solved.

Fixed style issues

30ffb1f

Fixed dataset selection not being centered

0d2e363

upgraded webpack to 4.1.0

3d9472d

minor fix

a0a1040

Merged webpack upgrade to sl

243c588

fixed modules overwriting in webpack.config.dev.js

9ff709f

Update config/webpack.config.dev.js

ccf43f7

Co-authored-by: Dominik Moritz <domoritz@gmail.com>

Update config/webpack.config.lib.js

c722c68

Co-authored-by: Dominik Moritz <domoritz@gmail.com>

Replaced UglifyJs with Terser and version modification for gh-pages

f5c971d

Removed uglifyjs-webpack-plugin

95c26b4

Upgraded Typescript to 2.6.2

9897f33

And resolved the style issue.

Bumped Typescript version

b85357e

Update tsconfig.json

3bd8838

Bumped typescript and webpack version

3472661

Updated style to resolve style issue with style-loader

c0ae557

Version Bumps

49bd960

Version Bumps

29b99b2

Resolve conflict

85612a4

Update yarn.lock

72be369

Addressed the comments and fixed issue#871 and vega#872

8822adf

However, there still are errors when running jest

siyaoL1 added 2 commits April 20, 2022 16:04

Removed unused imports and fixed unreachable statement

6167d7f

More changes to address test issues

d86b3e7

Removed moduleNameMapper

40bec63

domoritz closed this Apr 29, 2022

domoritz reopened this Apr 29, 2022

siyaoL1 and others added 5 commits May 4, 2022 19:58

Fixed logic test error, still need to fix ui test

17ba44f

Cleaning up

638a82b

Still working on resolving UI Jest test errors

Fixed ReferenceError: regeneratorRuntime is not defined

efa2b87

Fixed ajv validation error, and cleaned up imports

01103ab

Merge branch 'master' into sl_3

6d04f84

siyaoL1 added 2 commits May 26, 2022 15:29

Unused variable fix

c82b01e

Merge branch 'sl_3' of https://github.com/siyaoL1/voyager into sl_3

5505e9a

Update yarn.lock

6356b67

domoritz approved these changes May 31, 2022

View reviewed changes

Addressed comments and removed unavailable datasets

5e29ab9

siyaoL1 added 2 commits June 1, 2022 08:57

Update yarn.lock

baebfd0

Updated datasets url and copied birdstrikes.json manually

df49148

Added support for CSV file type in datasetLoad function

0bd2706

Now the default dataset supports csv files from vega_datasets, such as birdstricks.csv.

Update dataset.ts

6b31272

Uh oh!

Conversation

siyaoL1 commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siyaoL1 commented Apr 7, 2022

Uh oh!

lgtm-com bot commented Apr 20, 2022

Uh oh!

lgtm-com bot commented Apr 26, 2022

Uh oh!

lgtm-com bot commented Apr 26, 2022

Uh oh!

domoritz commented Apr 29, 2022

Uh oh!

lgtm-com bot commented May 25, 2022

Uh oh!

domoritz commented May 27, 2022

Uh oh!

domoritz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

domoritz May 31, 2022

Choose a reason for hiding this comment

Uh oh!

domoritz May 31, 2022

Choose a reason for hiding this comment

Uh oh!

siyaoL1 commented Jun 1, 2022

Uh oh!

domoritz commented Jun 5, 2022

Uh oh!

lgtm-com bot commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

siyaoL1 commented Apr 6, 2022 •

edited

Loading

domoritz left a comment •

edited

Loading