Add validation guarding against parent node output references #3630
Conversation
src/vellum/workflows/nodes/displayable/bases/inline_prompt_node/node.py
Outdated
Show resolved
Hide resolved
| class_outputs = vars(node_cls.Outputs) | ||
|
|
||
| for name, value in class_outputs.items(): |
There was a problem hiding this comment.
[nit] we support iterating over the node class: for reference, value in node_cls.Outputs:
| continue | ||
|
|
||
| parent_node_class = node_value.outputs_class.__parent_class__ | ||
| if parent_node_class in node_cls.__mro__: |
There was a problem hiding this comment.
Is it valid to reference a sibling value in the same Outputs class? e.g.
class CustomNode(BaseNode):
class Outputs:
a: str = SomeOtherNode.Outputs.str_output
b: str = a
...From some quick testing the node_value for b points to SomeOtherNode.Outputs.str_output and it is correctly marked as valid
There was a problem hiding this comment.
Yea that's just standard output referencing of upstream nodes and how final output nodes work
| Validates that the node does not reference parent class outputs. | ||
| """ | ||
| errors = [] | ||
| for node_output in node_cls.Outputs: |
There was a problem hiding this comment.
re: #3630 (comment)
we're iterating on a subclass of BaseOutputs and not an instance, so we need to fetch the values separately
| continue | ||
|
|
||
| parent_node_class = node_value.outputs_class.__parent_class__ | ||
| if parent_node_class in node_cls.__mro__: |
There was a problem hiding this comment.
Yea that's just standard output referencing of upstream nodes and how final output nodes work
Prevent users from defining custom
Outputsclasses where an output references something from the parent classHere
custom_outputdoesn't get resolved during execution and remainsundefined. Separately, I think custom outputs for anInlinePromptNodewill just get dropped during serialization and possibly should be forbidden