Skip to content

Conversation

@fern-api
Copy link
Contributor

@fern-api fern-api bot commented Jan 23, 2026

This PR regenerates code to match the latest API Definition.

@vellum-automation vellum-automation bot changed the title 🌿 Fern Regeneration -- January 23, 2026 [PR PREVIEW - DO NOT MERGE] 🌿 Fern Regeneration -- January 23, 2026 Jan 23, 2026
@vellum-automation vellum-automation bot added the preview This PR was autogenerated for preview purposes only label Jan 23, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c3834e630

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 253 to 257
return self.request(
path=path,
method=method,
base_url=base_url,
params=params,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve form/multipart body on sync retries

The retry path in HttpClient.request calls self.request(...) without forwarding data or force_multipart. If a request used form data or forced multipart (e.g., file upload) and gets a retryable 4xx/5xx, the retried request will drop the body/format and can fail or act on an empty payload. Forward data and force_multipart in the retry call to keep request semantics consistent.

Useful? React with 👍 / 👎.

Comment on lines 452 to 456
return await self.request(
path=path,
method=method,
base_url=base_url,
params=params,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve form/multipart body on async retries

The async retry path mirrors the sync one and also omits data and force_multipart when calling self.request(...). This means any retry after a retryable response will resend a different payload for form/multipart requests, which can lead to failed retries or incorrect uploads. Pass through data and force_multipart here as well.

Useful? React with 👍 / 👎.

@vellum-automation vellum-automation bot deleted the fern-bot/2026-01-23T14-51Z branch January 23, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview This PR was autogenerated for preview purposes only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant