revert: reset to d25f88e #36
Conversation
Reverts the following commits: - 3915874 fix: pin TipTap versions with explicit @tiptap/pm dependency - a4f7dd1 fix: add pnpm overrides to resolve version conflicts - bccaa67 feat: skip version update pipeline if no changes needed - b58e0a8 feat: add turbo-ignore to skip unchanged app builds on Vercel - 3957ffb fix: remove explicit pnpm version from workflows 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "@veltdev/tiptap-crdt-react": "^4.5.9-beta.4", | ||
| "@veltdev/blocknote-crdt-react": "4.5.0-beta.3", | ||
| "@veltdev/codemirror-crdt-react": "4.5.8", | ||
| "@veltdev/reactflow-crdt": "4.5.8", |
There was a problem hiding this comment.
pnpm overrides moved to wrong field, no longer applied
The overrides field was moved from pnpm.overrides to a root-level overrides field. In pnpm, package overrides must be placed under pnpm.overrides in package.json. The root-level overrides field is an npm-specific feature and is ignored by pnpm. This is confirmed by the pnpm-lock.yaml diff which shows the overrides: section was completely removed from the lockfile, meaning the version overrides for @veltdev/* packages are no longer being applied. This could cause version conflicts and unexpected dependency resolution.
| "installCommand": "pnpm install", | ||
| "ignoreCommand": "npx turbo-ignore", | ||
| "buildCommand": "npm run build", | ||
| "installCommand": "cd ../.. && npm install", |
There was a problem hiding this comment.
Vercel config uses npm instead of pnpm
The Vercel configuration was changed to use npm run build and npm install while the monorepo uses pnpm (as specified by packageManager: "[email protected]" in the root package.json). Using npm will not respect the pnpm-lock.yaml lockfile, potentially installing different dependency versions and not properly handling pnpm workspace configurations. The installCommand of cd ../.. && npm install further suggests misalignment with the pnpm-based monorepo setup.
Reverts the following commits:
🤖 Generated with Claude Code
Pull Request
Description
Type of Change
Monorepo Structure Checklist
If adding a new demo, ensure you've followed the 5-level structure:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/package.jsonwith scoped name:@apps/<framework>-<document>-<library-or-solution>-<demo>pnpm --filter <package-name> buildpnpm --filter <package-name> devDeployment Checklist
If this demo should be deployed:
Testing
pnpm -w install && pnpm -w buildDocumentation
master-sample-app(if applicable)Related Issues
Screenshots/Videos
Additional Context
For Reviewers
Demo Location
Path:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/Package name:
@apps/<...>How to Test
Structure Verification
The demo follows the 5-level hierarchy:
Documentation: See README_MONOREPO.md and docs/structure.md for more details on the monorepo structure.
Note
pnpm@10and simplifyupdate-velt-versions.ymlby removing the separate check job; determine mode at runtime (check/dry-run/update) and update step conditions. Minor CI tweak to set pnpm v10 inci.yml.vercel.jsonfiles and changemaster-sample-app/vercel.jsonto usenpm run buildand monorepo rootnpm install.@tiptap/*intiptap-comments-demoto the v2 line; keep CRDT TipTap demo on v3 with caret range bumps; adjust transitive versions inpnpm-lock.yaml.overridesinpackage.json(not underpnpm.overrides), drop thevercel:configscript, and deletescripts/add-vercel-config.js.Written by Cursor Bugbot for commit aa3831e. This will update automatically on new commits. Configure here.