fix: resolve Velt auth timing issue in master-sample-app iframes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first load, demo iframes would get stuck because Velt SDK tried to connect before authentication completed (~8s). This fix waits for auth to complete, then refreshes the iframes. Subsequent visits skip the delay by checking a localStorage flag per demo origin. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Force refresh by resetting src | ||
| iframe1Ref.current.src = url | ||
| } | ||
| }, VELT_AUTH_WAIT_MS) |
There was a problem hiding this comment.
Stale URL closure in timer causes wrong document
When the url prop changes (e.g., user clicks reset during the first 8-second wait), handleIframeLoad sets a new timer but doesn't cancel the existing one. The old timer's closure still captures the previous url value. When the old timer fires, it sets iframe.src to the stale URL, causing the iframe to briefly show the wrong document. The clearTimeout calls only exist in the unmount cleanup effect, not before setting new timers in handleIframeLoad.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first load, demo iframes would get stuck because Velt SDK tried to connect before authentication completed (~8s). This fix waits for auth to complete, then refreshes the iframes. Subsequent visits skip the delay by checking a localStorage flag per demo origin.
🤖 Generated with Claude Code
Pull Request
Description
Type of Change
Monorepo Structure Checklist
If adding a new demo, ensure you've followed the 5-level structure:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/package.jsonwith scoped name:@apps/<framework>-<document>-<library-or-solution>-<demo>pnpm --filter <package-name> buildpnpm --filter <package-name> devDeployment Checklist
If this demo should be deployed:
Testing
pnpm -w install && pnpm -w buildDocumentation
master-sample-app(if applicable)Related Issues
Screenshots/Videos
Additional Context
For Reviewers
Demo Location
Path:
apps/<framework>/<document>/<type>/<implementation>/<library-or-solution>/<demo>/Package name:
@apps/<...>How to Test
Structure Verification
The demo follows the 5-level hierarchy:
Documentation: See README_MONOREPO.md and docs/structure.md for more details on the monorepo structure.
Note
Addresses demo iframe stalls caused by Velt SDK auth timing.
IframePairwaits ~8s for Velt auth, then refreshes iframes once; marks origins as initialized vialocalStorage(velt-initialized-<origin>) to skip future delays. Adds refs/timers with unmount cleanup and shows an "Initializing" overlay until refresh completes.SampleViewerkeys iframes only bysample.metadata.id(notdocumentId) to prevent remounts while document IDs change; continues to appenddocumentIdto iframe URLs and gates rendering until ready.page.tsxand viewer components.Written by Cursor Bugbot for commit 20163cf. This will update automatically on new commits. Configure here.