Add Vercel deploy config and platform specific tweaks #75
Draft
dmi3y wants to merge 17 commits intovendurehq:masterfrom
Draft
Add Vercel deploy config and platform specific tweaks #75dmi3y wants to merge 17 commits intovendurehq:masterfrom
dmi3y wants to merge 17 commits intovendurehq:masterfrom
Conversation
[DO NOT MERGE] Fix vercel no route convention
✅ Deploy Preview for inspiring-boba-355f4d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-vendure ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
Oh, I see now it's broken on Netlify deploy :( PS: Though I see same broken deploys on previously merged PR 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assume Vercel does some pre-optimization and if left as safe import it breaks deployment, that likely increases bundle size though. Not sure what could be a better alternative.
related to #67