Fix for nested routes rendering issue#93
Open
kevin-coscarelli wants to merge 2 commits intovendurehq:masterfrom
Open
Fix for nested routes rendering issue#93kevin-coscarelli wants to merge 2 commits intovendurehq:masterfrom
kevin-coscarelli wants to merge 2 commits intovendurehq:masterfrom
Conversation
✅ Deploy Preview for inspiring-boba-355f4d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-vendure ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This looks good to me |
axbegue
added a commit
to axbegue/storefront-remix-starter
that referenced
this pull request
Feb 12, 2025
|
Much much appreciated the effort. |
|
@dylviz Please merge this 🙏 |
Contributor
I think we'd need Michael for that. He's pretty busy though, might be faster to just throw the fix into your code if it's a blocker. |
|
I had the same issue. I suspect this is a regression from #90. |
wayinone
added a commit
to wayinone/ddiligence-front
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for nested routes rendering issue as described here: #92
Removing manual route generation seems to have fiuxed the issue:
