fix(core): Exclude seller orders when counting promotion usage

[twlite]

Description

This PR updates promotion-service to exclude seller orders when counting promotion usage. Fixes #3042

Breaking changes

N/A

Screenshots

N/A

Checklist

📌 Always:

• I have set a clear title
• My PR is small and contains a single feature
• I have checked my own PR

👍 Most of the time:

• I have added or updated test cases
• I have updated the README if needed

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
docs	Ready	Preview	Jan 22, 2026 8:43am
vendure-storybook	Ready	Preview, Comment	Jan 22, 2026 8:43am

[coderabbitai]

Walkthrough

Updated promotion-service queries to exclude Seller-type orders when counting promotion usages. Two methods—countPromotionUsagesForCustomer and countPromotionUsages—now filter out orders that are inactive and not of OrderType.Seller; an import of OrderType was added.

Changes

Cohort / File(s)	Change Summary
Promotion service update packages/core/src/service/services/promotion.service.ts	Added import of OrderType and updated countPromotionUsagesForCustomer and countPromotionUsages query builders to exclude orders where order.active = false and order.type != OrderType.Seller.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description includes a clear summary linked to issue #3042, notes no breaking changes, and the checklist reflects completion of core requirements.
Linked Issues check	✅ Passed	The code changes directly address issue #3042 by excluding Seller-type orders from promotion usage counts in both required query builders.
Out of Scope Changes check	✅ Passed	All changes are focused on the specific objective of excluding seller orders from promotion usage counting; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The PR title accurately summarizes the main change: excluding seller orders when counting promotion usage, which directly addresses the issue of incorrect promotion usage counting for split orders.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e235d85 and 61c9362.

📒 Files selected for processing (1)

• packages/core/src/service/services/promotion.service.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: e2e tests (20.x, mariadb)
• GitHub Check: e2e tests (20.x, postgres)
• GitHub Check: e2e tests (24.x, postgres)
• GitHub Check: e2e tests (20.x, sqljs)
• GitHub Check: e2e tests (24.x, mariadb)
• GitHub Check: e2e tests (24.x, sqljs)
• GitHub Check: build (24.x)
• GitHub Check: unit tests (24.x)
• GitHub Check: unit tests (20.x)
• GitHub Check: build (22.x)
• GitHub Check: build (20.x)
• GitHub Check: publish_install (macos-latest, 22.x)
• GitHub Check: publish_install (ubuntu-latest, 22.x)
• GitHub Check: publish_install (ubuntu-latest, 20.x)
• GitHub Check: publish_install (windows-latest, 20.x)
• GitHub Check: publish_install (macos-latest, 24.x)
• GitHub Check: publish_install (macos-latest, 20.x)
• GitHub Check: publish_install (windows-latest, 22.x)
• GitHub Check: publish_install (ubuntu-latest, 24.x)
• GitHub Check: publish_install (windows-latest, 24.x)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[twlite]

@dlhck anything preventing this from being merged?

[dlhck]

@twlite will be reviewed soon.