Guarding against empty polygons which would otherwise crash.#4
Open
DoctorLoki wants to merge 1 commit intovenicegeo:masterfrom
Open
Guarding against empty polygons which would otherwise crash.#4DoctorLoki wants to merge 1 commit intovenicegeo:masterfrom
DoctorLoki wants to merge 1 commit intovenicegeo:masterfrom
Conversation
Author
|
@jyutzler Maybe you could take a look at this simple change request? |
Contributor
|
Sorry, I am no longer affiliated with this project. @matthewhanson @smesdaghi can you take a look? |
Author
|
Thanks Jeff! Any word from @matthewhanson or @smesdaghi yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing coords into the geos.NewPolygon calls, there was a lack of checking whether the coordsArray was empty before dereferencing that array, potentially causing crashes, e.g. while trying to unmarshal JSON. Adding these guards avoids the crashes and results in detectable errors instead.