Add an automatic module name to the MANIFEST

[LonelyMidoriya]

Summary by CodeRabbit

• Chores
  • Added explicit Automatic-Module-Name entries to JAR manifests across multiple plugins to improve module naming and compatibility.
  • Updated project parent Maven version to 1.29.6.

[coderabbitai]

Walkthrough

Add maven-jar-plugin configurations that set Automatic-Module-Name manifest entries in multiple plugin POMs and update the parent POM version from 1.29.1 to 1.29.6.

Changes

Cohort / File(s)	Summary
Plugin manifest configuration embeddedfileSample-plugin/pom.xml, fontSample-plugin/pom.xml, fontType-plugin/pom.xml, iccdump-plugin/pom.xml, iccprofileSample-plugin/pom.xml, imageSample-plugin/pom.xml, jpylyzer-plugin/pom.xml, mediaconch/pom.xml, metsMetadata-plugin/pom.xml, ots-plugin/pom.xml, plugins/pom.xml	Added org.apache.maven.plugins:maven-jar-plugin under <build><plugins> with <archive><manifestEntries><Automatic-Module-Name> set to the module name appropriate for each POM (e.g., org.verapdf.plugin.<name> or org.verapdf.plugins).
Parent version update pom.xml	Updated <parent><version> from 1.29.1 to 1.29.6.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Changes are repetitive and limited to POM metadata.
• Pay attention to correctness of each Automatic-Module-Name value (typos, valid Java module name characters).
• Verify plugins/pom.xml module name org.verapdf.plugins and the parent version bump for CI impact.

Poem

🐰 I hop through POMs with manifest delight,
Adding names to jars in the soft moonlight,
Each plugin labeled, tidy and true,
A parent version nudge — a small carrot chew.
Build fields hum; the rabbit hops through.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding automatic module name entries to JAR manifests across multiple plugin POM files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch automatic-module-name

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7176d14 and 64c0404.

📒 Files selected for processing (1)

• iccprofileSample-plugin/pom.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Checkout and Build (25)
• GitHub Check: Checkout and Build (8)
• GitHub Check: Checkout and Build (21)
• GitHub Check: Checkout and Build (11)
• GitHub Check: Checkout and Build (17)
• GitHub Check: Codacy Static Code Analysis

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

fontSample-plugin/pom.xml (1)

58-72: Fix indentation at line 58.

The <build> opening tag at line 58 has 4 spaces of indentation when it should align with other top-level project elements. Review the file's existing indentation pattern and correct to maintain consistency.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3d1bf5 and 835309d.

📒 Files selected for processing (12)

• embeddedfileSample-plugin/pom.xml (1 hunks)
• fontSample-plugin/pom.xml (1 hunks)
• fontType-plugin/pom.xml (1 hunks)
• iccdump-plugin/pom.xml (1 hunks)
• iccprofileSample-plugin/pom.xml (1 hunks)
• imageSample-plugin/pom.xml (1 hunks)
• jpylyzer-plugin/pom.xml (1 hunks)
• mediaconch/pom.xml (1 hunks)
• metsMetadata-plugin/pom.xml (1 hunks)
• ots-plugin/pom.xml (1 hunks)
• plugins/pom.xml (1 hunks)
• pom.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Quality Assurance
• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (9)

pom.xml (1)

31-31: Verify parent POM version bump compatibility.

The parent version was updated from 1.29.1 to 1.29.6. Ensure that this version upgrade is necessary for the Automatic-Module-Name feature and doesn't introduce breaking changes or dependency conflicts. Consider documenting the rationale in the PR description if not already present.

metsMetadata-plugin/pom.xml (1)

66-76: LGTM!

The maven-jar-plugin configuration is correctly positioned before the maven-assembly-plugin, and the Automatic-Module-Name value properly reflects the module structure.

fontType-plugin/pom.xml (1)

42-56: LGTM!

The maven-jar-plugin configuration is correctly formatted with proper indentation and naming consistent with the module's artifact ID.

mediaconch/pom.xml (1)

58-72: LGTM!

The maven-jar-plugin configuration is correctly formatted and the module name appropriately reflects the artifact ID.

plugins/pom.xml (1)

97-107: LGTM!

The maven-jar-plugin configuration correctly names the aggregator module as org.verapdf.plugins (without the .plugin suffix), which is appropriate for the parent module.

embeddedfileSample-plugin/pom.xml (1)

58-72: LGTM!

The maven-jar-plugin configuration is correctly formatted with proper naming reflecting the artifact ID.

iccdump-plugin/pom.xml (1)

42-56: Build configuration looks good.

The maven-jar-plugin configuration correctly sets the Automatic-Module-Name manifest entry for Java 9+ module system support. The module name org.verapdf.iccdump.plugin maps cleanly to the artifact ID.

jpylyzer-plugin/pom.xml (1)

57-72: Build configuration looks good.

The maven-jar-plugin configuration properly defines the Automatic-Module-Name for Java 9+ module system support. The module name org.verapdf.jpylyzer.plugin aligns with the artifact ID.

imageSample-plugin/pom.xml (1)

58-72: Build configuration looks good.

The maven-jar-plugin configuration correctly sets the Automatic-Module-Name manifest entry. The module name org.verapdf.imageSample.plugin properly reflects the artifact ID.