Skip to content
This repository was archived by the owner on Feb 18, 2026. It is now read-only.

Comments

Refactor footer component and update API root paths in services#351

Open
vsanse wants to merge 1 commit intoveraPDF:masterfrom
vsanse:dom_setup
Open

Refactor footer component and update API root paths in services#351
vsanse wants to merge 1 commit intoveraPDF:masterfrom
vsanse:dom_setup

Conversation

@vsanse
Copy link

@vsanse vsanse commented Jul 10, 2025

No description provided.

@KateOrient
Copy link
Contributor

Hi @vsanse. Thank you so much for your contribution - we really appreciate the time and effort you put into this!

I reviewed the changes, and there are a few issues preventing us from merging the PR as-is. Specifically:

  • The replacement of REACT_APP_API_ROOT environment variable with a static value reduces flexibility and could cause issues across different environments that we use. Please consider using an enviroment variable on your side or create a fork to apply this change.

  • The removal of the <Footer/> componet isn't something we can accept, as it plays an important role in our layout and user experience. Instead please consider conditional rendering of footer info in case some data is missing.

  • Please remove console.log's that were used for testing purposes.

If you’re open to making some adjustments, I’d be happy to take another look!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants