Skip to content

Adding support for CMKs on application updates and fixing missing description parameter on create/update_app() #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjarrettveracode merged 1 commit into from
Mar 6, 2025
Merged

Adding support for CMKs on application updates and fixing missing description parameter on create/update_app() #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions veracode_api_py/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,22 +111,25 @@ def get_app(self, guid: UUID = None, legacy_id=None):
def get_app_by_name(self, appname):
return Applications().get_by_name(appname)

def create_app(self, app_name, business_criticality, business_unit: UUID = None, teams=[],
def create_app(self, app_name, business_criticality, description: str=None, business_unit: UUID = None, teams=[],
policy_guid = None, custom_fields=[],bus_owner_name = None, bus_owner_email = None,
git_repo_url = None, custom_kms_alias = None):
return Applications().create(app_name=app_name, business_criticality=business_criticality,
return Applications().create(app_name=app_name, description=description,
business_criticality=business_criticality,
business_unit=business_unit, teams=teams, policy_guid=policy_guid,
custom_fields=custom_fields, bus_owner_name=bus_owner_name,
bus_owner_email=bus_owner_email, git_repo_url=git_repo_url,
custom_kms_alias=custom_kms_alias)

def update_app(self, guid: UUID, app_name, business_criticality, business_unit: UUID = None, teams=[],
def update_app(self, guid: UUID, app_name, business_criticality, description: str=None, business_unit: UUID = None, teams=[],
policy_guid = None, custom_fields=[], bus_owner_name=None, bus_owner_email=None,
git_repo_url = None):
return Applications().update(guid=guid, app_name=app_name, business_criticality=business_criticality,
git_repo_url = None, custom_kms_alias=None):
return Applications().update(guid=guid, app_name=app_name, description=description,
business_criticality=business_criticality,
business_unit=business_unit, teams=teams, policy_guid=policy_guid,
custom_fields=custom_fields, bus_owner_name=bus_owner_name,
bus_owner_email=bus_owner_email, git_repo_url=git_repo_url)
bus_owner_email=bus_owner_email, git_repo_url=git_repo_url,
custom_kms_alias=custom_kms_alias)

def delete_app(self, guid: UUID):
return Applications().delete(guid)
Expand Down
7 changes: 3 additions & 4 deletions veracode_api_py/applications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ def create(self,app_name:str ,business_criticality, description: str=None, busin

def update(self,guid: UUID,app_name:str, business_criticality, description: str=None, business_unit: UUID=None,
teams=[], policy_guid:UUID=None, custom_fields=[],
bus_owner_name=None,bus_owner_email=None, git_repo_url=None):
bus_owner_name=None,bus_owner_email=None, git_repo_url=None, custom_kms_alias: str=None):
return self._create_or_update("UPDATE",app_name=app_name,business_criticality=business_criticality,
description=description,business_unit=business_unit,teams=teams,guid=guid,
policy_guid=policy_guid, custom_fields=custom_fields,
bus_owner_name=bus_owner_name,bus_owner_email=bus_owner_email,
git_repo_url=git_repo_url)
git_repo_url=git_repo_url, custom_kms_alias=custom_kms_alias)

def delete(self,guid: UUID):
uri = 'appsec/v1/applications/{}'.format(guid)
Expand Down Expand Up @@ -100,8 +100,7 @@ def _create_or_update(self,method,app_name: str, business_criticality, descripti
gru = { 'git_repo_url': git_repo_url}
app_def.update(gru)

if (custom_kms_alias != None) & (method=='CREATE'):
# custom_kms_alias currently only supported at creation
if (custom_kms_alias != None):
app_def.update({"custom_kms_alias": custom_kms_alias})

payload = json.dumps({"profile": app_def})
Expand Down
Loading