Skip to content

feat: consume published verana-types package#327

Open
matlux wants to merge 2 commits intomainfrom
feat/align-verana-type-amino
Open

feat: consume published verana-types package#327
matlux wants to merge 2 commits intomainfrom
feat/align-verana-type-amino

Conversation

@matlux
Copy link
Member

@matlux matlux commented Mar 13, 2026

Summary

  • consume the published @verana-labs/verana-types@0.9.5-pr-268.1 package instead of the local generated codec/Amino implementation
  • replace the frontend-owned registry/Amino wiring with createVeranaRegistry() and createVeranaAminoTypes() from the package
  • remove the now-unused local app/msg/amino-converter/* layer and switch the remaining codec imports to the package surface
  • exclude the local verana-blockchain workspace symlink from TypeScript discovery so local builds do not walk backend test files

Context

This is the frontend companion to verana#268.

The backend work was published as prerelease verana v0.9.5-pr-268.1, which published:

  • npm package: @verana-labs/verana-types@0.9.5-pr-268.1
  • npm dist-tag: next

That keeps latest on 0.9.4 while giving this branch an honest published dependency to validate against.

Validation

  • npx tsc --noEmit
  • npm run build

Both passed locally against the published package version above.

@AirKyzzZ
Copy link
Collaborator

@matlux Looks good overall

Two things:

  1. The dependency is pinned to the prerelease 0.9.5-pr-268.1. What's the plan for bumping to stable once chore(main): release 0.7.0 #268 lands on the backend?
  2. Is there a follow-up planned to remove the proto-codecs/ directory entirely afterwards ?

Also be careful there's merge conflicts maybe needs to quick rebase

@genaris
Copy link
Member

genaris commented Mar 13, 2026

@matlux Looks good overall

Two things:

  1. The dependency is pinned to the prerelease 0.9.5-pr-268.1. What's the plan for bumping to stable once chore(main): release 0.7.0 #268 lands on the backend?
  2. Is there a follow-up planned to remove the proto-codecs/ directory entirely afterwards ?

Also be careful there's merge conflicts maybe needs to quick rebase

@AirKyzzZ were you able to test this branch and confirm that verana-frontend works properly (signs transactions, etc.)?

@AirKyzzZ
Copy link
Collaborator

@genaris Sure I could test, i'll comment here what i find

@AirKyzzZ
Copy link
Collaborator

@genaris Tested the branch locally on Chrome with Keplr wallet, all transactions sign and broadcast successfully via Amino:

  • DID creation (MsgAddDID) — OK
  • Governance Framework Document (MsgAddGovernanceFrameworkDocument) — OK
  • Credential Schema creation (MsgCreateCredentialSchema) — OK

These cover the main type conversion edge cases (simple strings, uint64/Long fields, OptionalUInt32 wrappers). End-to-end migration looks good from the frontend side.

@genaris
Copy link
Member

genaris commented Mar 13, 2026 via email

@antoniobenavidesvallejo
Copy link
Collaborator

@AirKyzzZ Of the transactions you mentioned, only the third is representative of the problematic cases. The first one is no longer even used.

It's necessary to test all the credential schema transactions and permission transactions. The permission transactions were the last ones to cause problems, and specific adjustments had to be made to the Amino converters.

Copy link
Collaborator

@antoniobenavidesvallejo antoniobenavidesvallejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the library includes the amino converter and the protocols indicated in the verana-types issue, it should only be necessary to change the include files and all transactions should work fine.

@matlux
Copy link
Member Author

matlux commented Mar 13, 2026

Yes @antoniobenavidesvallejo , fair point that the perm transactions are the most sensitive Amino cases and that the current frontend checks do not cover all of them yet.

This frontend PR shows that the frontend can consume the published package and that the package swap works end to end. The deeper Amino coverage for credential schema and especially permission transactions belongs on the verana side, because that is the repo that builds and publishes verana-types.

So I agree those are the sensitive cases, but I’d treat that as backend test coverage enhancement rather than something this frontend PR itself needs to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants