Skip to content

ci: restore full prerelease release assets#269

Merged
matlux merged 2 commits intomainfrom
fix/ci-multi-binaries
Mar 11, 2026
Merged

ci: restore full prerelease release assets#269
matlux merged 2 commits intomainfrom
fix/ci-multi-binaries

Conversation

@matlux
Copy link
Member

@matlux matlux commented Mar 11, 2026

Summary

  • restore the full GitHub prerelease asset list for binaries, checksums, and ts-proto tarball
  • keep the prerelease-only trigger and document why the workflow intentionally avoids published
  • fail the workflow if expected release assets are missing locally or not attached to the GitHub prerelease

Root cause

Commit 3acc90a added the canonical image job in the middle of the softprops/action-gh-release multiline files: block. The workflow stayed valid YAML, but the release upload list was truncated to veranad-linux-amd64 only.

Validation

  • parsed .github/workflows/buildBinaries.yml successfully with Ruby YAML
  • ran actionlint; it reported pre-existing workflow issues unrelated to this regression (old action versions and the existing github.event.inputs.NAME_SPACE reference), but no new syntax issue from this change

@matlux matlux requested a review from pratikasr March 11, 2026 15:16
Copy link
Contributor

@pratikasr pratikasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matlux matlux requested a review from lotharking March 11, 2026 15:19
@matlux matlux merged commit a20488f into main Mar 11, 2026
5 checks passed
@matlux matlux deleted the fix/ci-multi-binaries branch March 11, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants