feat: add architecture-colocate-contexts rule#121
Open
nouamanecodes wants to merge 1 commit intovercel-labs:mainfrom
Open
feat: add architecture-colocate-contexts rule#121nouamanecodes wants to merge 1 commit intovercel-labs:mainfrom
nouamanecodes wants to merge 1 commit intovercel-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing rules cover component composition and performance optimization well, but there's no guidance on where context files should live in a codebase. This leads to a common antipattern: dumping all contexts into a top-level
src/contexts/folder regardless of scope.When contexts are scattered away from the components that use them:
Solution
This adds a new
architecture-colocate-contextsrule that recommends placing context definitions adjacent to the components that consume them.The rule covers:
Example
Instead of:
Co-locate:
This complements the composition-patterns skill by providing the structural container for those patterns.