fix: clarify use client directive placement in code examples#137
Open
Leonccaa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: clarify use client directive placement in code examples#137Leonccaa wants to merge 1 commit intovercel-labs:mainfrom
Leonccaa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the placement of 'use client' directive in code examples. The directive should be shown as being in a separate file or at the top of the file, not inline within code blocks showing RSC examples.
Changes
This fixes issue #136 which reports that showing 'use client' inline in RSC code examples is confusing and technically incorrect.