fix: escape regex special characters in log error pattern matching #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
calculateErrorPriorityfunction inmcp-server/app/mcp/tools.tscreates a regex pattern from error lines to count how many similar errors have occurred (used to boost priority for recurring errors). The pattern is built by replacing digit sequences with\d+so that errors differing only in timestamps or line numbers are grouped together.However, log lines commonly contain characters that have special meaning in regex:
[12:34:56.789]— square brackets define character classes(connection closed)— parentheses define capture groupsC:\Users\...— backslashes are escape charactersexpected 5, got 10— could contain+,*,?When these unescaped characters were passed to
new RegExp(), it would throw errors like:This crashed the error analysis flow entirely.
Solution
\d+, escape all special regex characters ([.*+?^${}()|[\]\\]) using the standard\\$&replacement patternincludes()) rather than crashingTest plan
🤖 Generated with Claude Code