chore(ai): formally include already supported onLanguageModelCallStart and onLanguageModelCallEnd in ToolLoopAgentSettings type - #20286
Merged
felixarntz merged 2 commits intoSep 3, 2026
Conversation
…in ToolLoopAgentSettings
n1ckoates
approved these changes
Sep 3, 2026
felixarntz
enabled auto-merge (squash)
September 3, 2026 17:39
felixarntz
deleted the
fa/chore-tool-loop-agent-language-model-lifecycle-callbacks
branch
September 3, 2026 17:48
Contributor
|
🚀 Published in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
ToolLoopAgentalready forwardsonLanguageModelCallStartandonLanguageModelCallEndtogenerateTextandstreamText, butToolLoopAgentSettingsdid not declare them. This appears to be an oversight, given the other lifecycle callbacks were already explicitly included in theToolLoopAgentSettingstype.Summary
ToolLoopAgentSettings.End-to-End Verification
N/A. This change formalizes existing runtime behavior.
Checklist
pnpm changesetin the project root)