Skip to content

Fix: Convert cookie attribute "sameSite" of TRUE to "strict" as per documentation#1078

Closed
Heinrich-Barth wants to merge 2 commits intovercel:mainfrom
Heinrich-Barth:main
Closed

Fix: Convert cookie attribute "sameSite" of TRUE to "strict" as per documentation#1078
Heinrich-Barth wants to merge 2 commits intovercel:mainfrom
Heinrich-Barth:main

Conversation

@Heinrich-Barth
Copy link

This PR addresses the following issue:

Per documentation, the cookie attribute sameSite should convert the boolean value of "true" to "strict".

This is not the case. Instead, a cookie will have an invalid value, e.g.

session=anyvalue; Path=/; SameSite=true

expected cookie String should (per documentation) should be

session=anyvalue; Path=/; SameSite=strict

This patch converts the boolean true to "strict" as per documentation.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 7f0ff37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Jan 9, 2025

@Heinrich-Barth is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@Heinrich-Barth
Copy link
Author

Am I correct in assuming that this repository is not maintained anymore?

@Heinrich-Barth Heinrich-Barth closed this by deleting the head repository Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant