Skip to content

feat: Use Link component for sidebar links #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haydenbleasel merged 1 commit into from
Feb 9, 2025
Merged

feat: Use Link component for sidebar links #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions apps/app/app/(authenticated)/components/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import {
} from 'lucide-react';
import type { ReactNode } from 'react';
import { Search } from './search';
import Link from 'next/link';

type GlobalSidebarProperties = {
readonly children: ReactNode;
Expand Down Expand Up @@ -224,10 +225,10 @@ export const GlobalSidebar = ({ children }: GlobalSidebarProperties) => {
>
<SidebarMenuItem>
<SidebarMenuButton asChild tooltip={item.title}>
<a href={item.url}>
<Link href={item.url}>
<item.icon />
<span>{item.title}</span>
</a>
</Link>
</SidebarMenuButton>
{item.items?.length ? (
<>
Expand All @@ -242,9 +243,9 @@ export const GlobalSidebar = ({ children }: GlobalSidebarProperties) => {
{item.items?.map((subItem) => (
<SidebarMenuSubItem key={subItem.title}>
<SidebarMenuSubButton asChild>
<a href={subItem.url}>
<Link href={subItem.url}>
<span>{subItem.title}</span>
</a>
</Link>
</SidebarMenuSubButton>
</SidebarMenuSubItem>
))}
Expand All @@ -263,10 +264,10 @@ export const GlobalSidebar = ({ children }: GlobalSidebarProperties) => {
{data.projects.map((item) => (
<SidebarMenuItem key={item.name}>
<SidebarMenuButton asChild>
<a href={item.url}>
<Link href={item.url}>
<item.icon />
<span>{item.name}</span>
</a>
</Link>
</SidebarMenuButton>
<DropdownMenu>
<DropdownMenuTrigger asChild>
Expand Down Expand Up @@ -311,10 +312,10 @@ export const GlobalSidebar = ({ children }: GlobalSidebarProperties) => {
{data.navSecondary.map((item) => (
<SidebarMenuItem key={item.title}>
<SidebarMenuButton asChild>
<a href={item.url}>
<Link href={item.url}>
<item.icon />
<span>{item.title}</span>
</a>
</Link>
</SidebarMenuButton>
</SidebarMenuItem>
))}
Expand Down
Loading