[next 14] Enforce eslint-plugin-react-hooks v4

[lorand-horvath]

@eps1lon @feedthejim Please see the reason for this in #71291

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 7f957bf

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 7f957bf

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[eps1lon]

It's not a critical fix. Technically breaking again if you already relied on the new behavior considering for how long this has been out there. I don't see a path to safely backport nor the urgency to do this. You could always use resolutions or overrides to fix it.

[lorand-horvath]

@eps1lon If left unfixed, new next 14 apps will actually install a very old canary eslint-plugin-react-hooks@5 from July 2023 as I mentioned before, instead of 4.6.2. And that's a regression, if you ask me.

Anyway, I won't spend more time on this. I already have an override in place, which works fine, as I already said at the very beginning here #71218 (comment)

Note to self: do not spend time on OSS - not worth it.

[eps1lon]

new next 14 apps will actually install a very old canary eslint-plugin-react-hooks@5 from July 2023 as I mentioned before, instead of 4.6.2. And that's a regression, if you ask me.

I agree. However, the change has been out there since 14.0 was released (actually since 13.4.9). So practically we can't revert that change at this point without risking breakage. Backporting is a taxing and risk operation so it's restricted to critical fixes. A dev-only issue that has a workaround does not fall into that category.

[lorand-horvath]

new next 14 apps will actually install a very old canary eslint-plugin-react-hooks@5 from July 2023 as I mentioned before, instead of 4.6.2. And that's a regression, if you ask me.

I agree. However, the change has been out there since 14.0 was released (actually since 13.4.9). So practically we can't revert that change at this point without risking breakage. Backporting is a taxing and risk operation so it's restricted to critical fixes. A dev-only issue that has a workaround does not fall into that category.

Funny. Setting 4.6.2 is not a backport. And using canary react in next.js isn't risky? C'mon...

[lorand-horvath]

Can this be merged please? eslint-plugin-react-hooks will still install the very old 5.0.0-canary-7118f5dd7-20230705 from July 2023 instead of the latest 4.6.2 from April 2024 as per https://github.com/vercel/next.js/blob/14-2-1/packages/eslint-config-next/package.json#L22

There's still no good explanation as to why has the plugin been pinned to a specific 5.0.0-canary, which is very old, older than 4.6.2.
It should really be updated to install the latest from v4 branch, i.e. ^4.6.2.