Skip to content

Remove experimental.reactOwnerStack flag #76021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Remove experimental.reactOwnerStack flag #76021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
93fa12b
Update `react@experimental`
vercel-release-bot Feb 13, 2025
fd7a4c4
Update `react`
vercel-release-bot Feb 13, 2025
6a3955f
Updated peer dependency references in apps
vercel-release-bot Feb 13, 2025
8cff4d8
Updated peer dependency references in libraries
vercel-release-bot Feb 13, 2025
89f6c8c
Update lockfile
vercel-release-bot Feb 13, 2025
82a453a
ncc-compiled
vercel-release-bot Feb 13, 2025
66b00bb
Disable flaky test
eps1lon Feb 14, 2025
c96d83e
Remove experimental.reactOwnerStack
eps1lon Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,16 @@
"pretty-ms": "7.0.0",
"random-seed": "0.3.0",
"react": "19.0.0",
"react-builtin": "npm:[email protected]cbbe8666-20250213",
"react-builtin": "npm:[email protected]32b0cad8-20250213",
"react-dom": "19.0.0",
"react-dom-builtin": "npm:[email protected]cbbe8666-20250213",
"react-dom-experimental-builtin": "npm:[email protected]cbbe8666-20250213",
"react-experimental-builtin": "npm:[email protected]cbbe8666-20250213",
"react-is-builtin": "npm:[email protected]cbbe8666-20250213",
"react-server-dom-turbopack": "19.1.0-canary-cbbe8666-20250213",
"react-server-dom-turbopack-experimental": "npm:[email protected]cbbe8666-20250213",
"react-server-dom-webpack": "19.1.0-canary-cbbe8666-20250213",
"react-server-dom-webpack-experimental": "npm:[email protected]cbbe8666-20250213",
"react-dom-builtin": "npm:[email protected]32b0cad8-20250213",
"react-dom-experimental-builtin": "npm:[email protected]32b0cad8-20250213",
"react-experimental-builtin": "npm:[email protected]32b0cad8-20250213",
"react-is-builtin": "npm:[email protected]32b0cad8-20250213",
"react-server-dom-turbopack": "19.1.0-canary-32b0cad8-20250213",
"react-server-dom-turbopack-experimental": "npm:[email protected]32b0cad8-20250213",
"react-server-dom-webpack": "19.1.0-canary-32b0cad8-20250213",
"react-server-dom-webpack-experimental": "npm:[email protected]32b0cad8-20250213",
"react-ssr-prepass": "1.0.8",
"react-virtualized": "9.22.3",
"relay-compiler": "13.0.2",
Expand All @@ -235,8 +235,8 @@
"resolve-from": "5.0.0",
"sass": "1.54.0",
"satori": "0.12.1",
"scheduler-builtin": "npm:[email protected]cbbe8666-20250213",
"scheduler-experimental-builtin": "npm:[email protected]cbbe8666-20250213",
"scheduler-builtin": "npm:[email protected]32b0cad8-20250213",
"scheduler-experimental-builtin": "npm:[email protected]32b0cad8-20250213",
"seedrandom": "3.0.5",
"semver": "7.3.7",
"shell-quote": "1.7.3",
Expand Down Expand Up @@ -277,10 +277,10 @@
"@types/react": "19.0.8",
"@types/react-dom": "19.0.3",
"jest-snapshot": "30.0.0-alpha.6",
"react": "19.1.0-canary-cbbe8666-20250213",
"react-dom": "19.1.0-canary-cbbe8666-20250213",
"react-is": "19.1.0-canary-cbbe8666-20250213",
"scheduler": "0.26.0-canary-cbbe8666-20250213"
"react": "19.1.0-canary-32b0cad8-20250213",
"react-dom": "19.1.0-canary-32b0cad8-20250213",
"react-is": "19.1.0-canary-32b0cad8-20250213",
"scheduler": "0.26.0-canary-32b0cad8-20250213"
},
"patchedDependencies": {
"[email protected]": "patches/[email protected]",
Expand Down
2 changes: 0 additions & 2 deletions packages/next/src/build/webpack/plugins/define-env-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,6 @@ export function getDefineEnv({
: undefined),
'process.env.__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY':
config.experimental.newDevOverlay || false,
'process.env.__NEXT_REACT_OWNER_STACK':
config.experimental.reactOwnerStack ?? false,
}

const userDefines = config.compiler?.define ?? {}
Expand Down
3 changes: 0 additions & 3 deletions packages/next/src/client/components/errors/stitched-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ const REACT_ERROR_STACK_BOTTOM_FRAME_REGEX = new RegExp(
)

export function getReactStitchedError<T = unknown>(err: T): Error | T {
if (!process.env.__NEXT_REACT_OWNER_STACK) {
return err
}
const isErrorInstance = isError(err)
const originStack = isErrorInstance ? err.stack || '' : ''
const originMessage = isErrorInstance ? err.message : ''
Expand Down
Loading
Loading