Skip to content

chore: Remove unused Map support from next/dynamic transform #82487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
+7 −17
Merged

chore: Remove unused Map support from next/dynamic transform #82487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions packages/next/src/build/babel/plugins/react-loadable-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,13 @@ OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWAR
*/
// This file is https://github.com/jamiebuilds/react-loadable/blob/master/src/babel.js
// Modified to also look for `next/dynamic`
// Modified to put `webpack` and `modules` under `loadableGenerated` to be backwards compatible with next/dynamic which has a `modules` key
// Modified to support `dynamic(import('something'))` and `dynamic(import('something'), options)
// - Modified to also look for `next/dynamic`
// - Modified to put `webpack` and `modules` under `loadableGenerated` to be
// backwards compatible with next/dynamic which has a `modules` key
// - Modified to support `dynamic(import('something'))` and
// `dynamic(import('something'), options)
// - Removed `Loadable.Map` support, `next/dynamic` uses overloaded arguments
// instead of a separate API

import type {
NodePath,
Expand Down Expand Up @@ -60,20 +64,6 @@ export default function ({

binding.referencePaths.forEach((refPath) => {
let callExpression = refPath.parentPath

if (
callExpression?.isMemberExpression() &&
callExpression.node.computed === false
) {
const property = callExpression.get('property')
if (
!Array.isArray(property) &&
property.isIdentifier({ name: 'Map' })
) {
callExpression = callExpression.parentPath
}
}

if (!callExpression?.isCallExpression()) return

let args = callExpression.get('arguments')
Expand Down
Loading