-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Improve locale access examples for i18n routing #84621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yoseph0524
wants to merge
3
commits into
vercel:canary
Choose a base branch
from
yoseph0524:canary
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSX code example has invalid syntax - the return statement contains text content without wrapping it in a JSX element.
View Details
Analysis
Invalid JSX syntax in internationalization documentation example
What fails: The
LocaleExample
component indocs/02-pages/02-guides/internationalization.mdx
(lines 226-230) has invalid JSX syntax - returns multiple text nodes without a wrapper elementHow to reproduce:
Result: Babel compilation fails with error:
Unexpected token, expected "," (7:14)
at the "Current locale:" text lineExpected: JSX requires multiple elements/text nodes to be wrapped in a parent element or Fragment per React documentation on Fragments. All other code examples in this file properly wrap content in JSX elements.