-
Notifications
You must be signed in to change notification settings - Fork 29.5k
[Testing] #84686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sokra
wants to merge
10
commits into
sokra/trace-compress
Choose a base branch
from
sokra/test-persistent-cache
base: sokra/trace-compress
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−27
Draft
[Testing] #84686
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7511e36
update petgraph
sokra 8f86b1b
WIP: enable trace_task_dirty feature
sokra 0a3f3e9
remove tracing restriction
sokra f102716
Turbopack: take task cache log before starting snapshot
sokra 4f264a7
enable verify_immutable
sokra 9937aea
add more tracing
sokra 38ae1ee
verify_serialization
sokra cbdd1ee
Turbopack: Add ChunkedVec test case
sokra 2750556
improve verify_serialization to check task type round trip
sokra b5403cf
WIP: print when storing a with_modules task
sokra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,10 +8,10 @@ | |
"scripts": { | ||
"clean": "node ../../scripts/rm.mjs native", | ||
"build-native": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --features plugin,image-extended --js false native", | ||
"build-native-release": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --release --features plugin,image-extended,tracing/release_max_level_info --js false native", | ||
"build-native-release-with-assertions": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --profile release-with-assertions --features plugin,image-extended,tracing/release_max_level_info --js false native", | ||
"build-native-release": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --release --features plugin,image-extended --js false native", | ||
"build-native-release-with-assertions": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --profile release-with-assertions --features plugin,image-extended --js false native", | ||
"build-native-no-plugin": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --features image-webp --js false native", | ||
"build-native-no-plugin-release": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --release --features image-webp,tracing/release_max_level_info --js false native", | ||
"build-native-no-plugin-release": "napi build --platform -p next-swc-napi --cargo-cwd ../../ --cargo-name next_swc_napi --release --features image-webp --js false native", | ||
"build-native-wasi": "npx --package=@napi-rs/[email protected] napi build --platform --target wasm32-wasip1-threads -p next-swc-napi --cwd ../../ --output-dir packages/next-swc/native --no-default-features", | ||
"build-wasm": "wasm-pack build ../../crates/wasm --scope=next", | ||
"cache-build-native": "[ -d native ] && echo $(ls native)", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unconditional debug
println!
statement will execute in production builds, printing to stdout for every task type containing "with_modules".View Details
📝 Patch Details
Analysis
Unguarded debug println in production builds prints task type information
What fails: The
save_snapshot()
method inturbopack/crates/turbo-tasks-backend/src/kv_backing_storage.rs
at lines 362-364 contains an unconditionalprintln!
statement that executes in all builds (debug and release), printing debug information whenever a task type name contains "with_modules".How to trigger: Any turbopack build that creates task types with "with_modules" in the name will print to stdout:
Result: Debug output is printed to stdout in production builds, cluttering logs with internal implementation details.
Expected: Debug output should only be printed when the
verify_serialization
feature is enabled, matching the pattern used for all other debugprintln!
statements in this file (lines 668, 676, 684, 764, 779).Evidence: Git commit
b5403cf031
explicitly marks this as "WIP: print when storing a with_modules task", confirming it's temporary debugging code that should be guarded or removed. All similar debug println statements in the same file are properly guarded with#[cfg(feature = "verify_serialization")]
.