Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
weird, but doesn't matter really |
Contributor
Author
|
yeah noticed that too... it is a compatible update i guess. CI is in charge of this decision :D |
2 tasks
Collaborator
Tests Passed |
Merging this PR will degrade performance by 6.89%
Performance Changes
Comparing 
Footnotes
|
Collaborator
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
bgw
approved these changes
Mar 6, 2026
Member
There was a problem hiding this comment.
Regarding the lockfile: IMO, we should either specify the exact LTS version range in Cargo.toml (https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#tilde-requirements) or we should specify the latest version (1.50.0) in Cargo.toml.
My preference is for the LTS version, but either is fine.
lukesandberg
force-pushed
the
update-tokio-1.47.3
branch
from
4d5015d to
14f1da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the workspace
tokiodependency from 1.43.0 to 1.47.3 (resolves to 1.50.0 in lockfile).The tokio 1.43.x LTS line expires March 2026. This moves to the 1.47.x LTS line (supported until September 2026).
Key changes included in this bump
select!is now budget-aware (1.44) — cooperates with tokio's cooperative schedulingworker_total_busy_duration,worker_park_count,worker_unpark_count(1.45)AtomicWaker::wake, eliminated unnecessarylfencein task queue (1.46-1.47)sync::SetOnce,Notify::notified_owned(),broadcast::WeakSender,biasedoption forjoin!/try_join!runtime::Handlemarked unwind-safe (1.45)socket20.5 → 0.6,windows-sys0.52 → 0.61Breaking changes (verified safe)
from_stdnow panics on blocking sockets — noTcpStream::from_stdcalls in codebaseLocalSet::{poll,drop}disallows blocking — noLocalSetusage in codebaseselect!budget awareness — behavioral change, should improve fairnessNew duplicate dependencies
socket2 v0.6.2added (v0.4 and v0.5 already existed due tohyper 0.14)Test plan
cargo checkpasses with no errors