Open
Conversation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
3 tasks
|
感谢反馈!我们看到了你的feature请求。我们会尽快处理。 |
Collaborator
Failing test suitesCommit: 661b039 | About building and testing Next.js
Expand output● app-root-param-getters - typecheck (simple) › should generate root-params.d.ts with correct types ● app-root-param-getters - typecheck (simple) › should be included via tsconfig glob pattern ● app-root-param-getters - typecheck (multiple-roots) › should generate root-params.d.ts with non-universal param |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate type definitions for
next/root-paramsfrom App Router root layouts.This adds a
root-params.d.tsfile under.next/typesduring build,next dev, andnext typegen, so imports fromnext/root-paramsget accurate autocomplete and type checking.What Changed
.next/types/root-params.d.tsfornext/root-paramsnext build/dev/typegenundefinedonly when a param is not present in every root layoutstring | string[] | undefinedwhen the same param name appears with different shapes across rootsroot-params.d.tswhen the feature is disabled or there are no root paramsWhy
next/root-paramsalready works at runtime, but its types were not tailored to the current app.This change closes that gap by generating declarations from the app's actual root layouts. Required params stay required for single-root apps, while multi-root apps correctly expose params that may be missing or have mixed segment shapes.
Testing
root-params.d.ts