Support pageExtensions in no-html-link-for-pages eslint rule#91094
Open
boris324 wants to merge 1 commit intovercel:canaryfrom
Open
Support pageExtensions in no-html-link-for-pages eslint rule#91094boris324 wants to merge 1 commit intovercel:canaryfrom
boris324 wants to merge 1 commit intovercel:canaryfrom
Conversation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53473
The
no-html-link-for-pagesESLint rule currently has hardcoded file extension matching (tsx,ts,jsx,js) in the URL parsing functions. This means projects using custompageExtensions(likemdx) in their Next.js config have those pages silently ignored by the lint rule.This PR makes the internal
parseUrlForPagesandparseUrlForAppDirfunctions accept an optionalpageExtensionsparameter, building the file extension regex dynamically instead of using the hardcoded pattern. The rule readspageExtensionsfromcontext.settings.next(same pattern used bygetRootDirsforrootDir) and passes it through.Users can configure it in their ESLint config:
{ "settings": { "next": { "pageExtensions": ["tsx", "ts", "jsx", "js", "mdx"] } } }When not configured, defaults to the original
["tsx", "ts", "jsx", "js"]behavior.Added tests covering custom page extensions detection and the default fallback behavior.