Skip to content

Turbopack: introduce ReferenceTypeCondition#91101

Open
mischnic wants to merge 1 commit intocanaryfrom
mischnic/ReferenceTypeCondition
Open

Turbopack: introduce ReferenceTypeCondition#91101
mischnic wants to merge 1 commit intocanaryfrom
mischnic/ReferenceTypeCondition

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Mar 9, 2026

Previously, we used RuleCondition::ReferenceType(ReferenceType). But there are some problem with using the type itself as a matcher:

  1. the sub types' Undefined variant (like CssReferenceSubType::Undefined) always matched all possible variants. So it was actually impossible to match exactly CssReferenceSubType::Undefined
  2. variants with more complex types were also impossible to match against, like ReferenceType::Inner(ResolvedVc<...>)

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 9, 2026
Copy link
Member Author

mischnic commented Mar 9, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic force-pushed the mischnic/ReferenceTypeCondition branch from 8b60108 to c8c3fc0 Compare March 9, 2026 14:04
@mischnic mischnic force-pushed the mischnic/ReferenceTypeCondition branch from c8c3fc0 to 9dadd5e Compare March 9, 2026 14:07
@mischnic mischnic requested a review from a team March 9, 2026 14:21
@mischnic mischnic marked this pull request as ready for review March 9, 2026 14:21
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing mischnic/ReferenceTypeCondition (9dadd5e) with canary (9c93972)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot
Copy link
Collaborator

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁▆▁
Cold (Ready in log) 438ms 438ms ▁▁▁▄▁
Cold (First Request) 1.241s 1.256s ▂▁▂▄▂
Warm (Listen) 457ms 456ms ▁▁▁▅▁
Warm (Ready in log) 441ms 447ms ▁▁▁▄▁
Warm (First Request) 350ms 354ms ▁▁▁▃▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁▁█
Cold (Ready in log) 433ms 433ms ▄▃▄▄█
Cold (First Request) 1.918s 1.938s ▂▂▂▂█
Warm (Listen) 456ms 456ms ▁▁▁▁█
Warm (Ready in log) 434ms 434ms ▄▃▃▃█
Warm (First Request) 1.941s 1.919s ▂▂▂▂█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.739s 3.766s ▁▁▁▄▁
Cached Build 3.799s 3.823s ▁▁▁▄▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.872s 13.935s ▁▁▁▁█
Cached Build 14.102s 14.059s ▁▁▁▁█
node_modules Size 477 MB 477 MB █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ✅ -11 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 766 B
Total 764 B 766 B ⚠️ +2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 453 B
Total 451 B 453 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 255 B 253 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.3 kB -
Total 233 kB 234 kB ⚠️ +745 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 256 kB 257 kB
Total 381 kB 382 kB ⚠️ +593 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 618 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.9 kB 43.9 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.6 kB 45.5 kB ✅ -43 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.07 MB 4.08 MB 🔴 +8.07 kB (+0%)
index.pack gzip 102 kB 103 kB
index.pack.old gzip 104 kB 104 kB
Total 4.28 MB 4.29 MB ⚠️ +8.4 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 171 kB 171 kB
app-page-tur...dev.js gzip 322 kB 322 kB
app-page-tur..prod.js gzip 171 kB 171 kB
app-page-tur...dev.js gzip 319 kB 319 kB
app-page-tur..prod.js gzip 169 kB 169 kB
app-page.run...dev.js gzip 319 kB 319 kB
app-page.run..prod.js gzip 169 kB 169 kB
app-route-ex...dev.js gzip 70.9 kB 70.9 kB
app-route-ex..prod.js gzip 49.3 kB 49.3 kB
app-route-tu...dev.js gzip 70.9 kB 70.9 kB
app-route-tu..prod.js gzip 49.3 kB 49.3 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49.1 kB 49.1 kB
app-route.ru...dev.js gzip 70.5 kB 70.5 kB
app-route.ru..prod.js gzip 49 kB 49 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB
pages-turbo....dev.js gzip 52.6 kB 52.6 kB
pages-turbo...prod.js gzip 38.5 kB 38.5 kB
pages.runtim...dev.js gzip 52.6 kB 52.6 kB
pages.runtim..prod.js gzip 38.5 kB 38.5 kB
server.runti..prod.js gzip 62 kB 62 kB
Total 2.84 MB 2.84 MB ⚠️ +3 B
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/9dadd5eb38be9fb6c785a8b6ffc8f74eabf60681/next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants