docs(turbopack): Fix all warnings in cargo doc --no-deps --workspace, and run rustdoc as part of our CI checks#91339
Open
docs(turbopack): Fix all warnings in cargo doc --no-deps --workspace, and run rustdoc as part of our CI checks#91339
cargo doc --no-deps --workspace, and run rustdoc as part of our CI checks#91339Conversation
nextjs-bot
added
created-by: Turbopack team
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bgw
commented
Mar 13, 2026
| "cache-build-native": "[ -d native ] && echo $(ls native)", | ||
| "rust-check-fmt": "cd ../..; cargo fmt -- --check", | ||
| "rust-check-clippy": "cargo clippy --workspace --all-targets -- -D warnings -A deprecated", | ||
| "rust-check-doc": "RUSTDOCFLAGS='-Zunstable-options --output-format=json' cargo doc --no-deps --workspace", |
Member
Author
There was a problem hiding this comment.
--output-format=json is faster than the default html formatter, and we only care about getting the warnings in this case.
Collaborator
Tests Passed |
Merging this PR will not alter performance
Comparing 
Footnotes
|
…`, and run rustdoc as part of our CI checks
bgw
force-pushed
the
bgw/fix-doc-warnings
branch
from
1181fe3 to
d25a353
Compare
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
mischnic
reviewed
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets
cargo docclean, and enables it in CI so that we won't regress it (I'm open to removing this if it proves to be annoying).I also cleaned up some documentation and even found some dead code (deleted
turbopack/crates/turbopack-dev-server/src/source/conditional.rs).