Skip to content

fix: base64 images#188

Merged
haydenbleasel merged 1 commit intovercel:mainfrom
2hu12:fix-base64-img
Oct 29, 2025
Merged

fix: base64 images#188
haydenbleasel merged 1 commit intovercel:mainfrom
2hu12:fix-base64-img

Conversation

@2hu12
Copy link
Copy Markdown
Contributor

@2hu12 2hu12 commented Oct 17, 2025

Description

In #170, ⁠harden-react-markdown was replaced with ⁠rehype-harden. However, ⁠react-markdown's ⁠defaultUrlTransform still applies. Therefore, following the default hardening option (⁠allowDataImages: true), we are also using a no-op (no operation) URL transform by default. We also export ⁠react-markdown's ⁠defaultUrlTransform for users who may want to utilize it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring (no functional changes)

Related Issues

Fixes #183
Closes #
Related to #

Changes Made

  • fix base64 images

Testing

  • All existing tests pass
  • Added new tests for the changes
  • Manually tested the changes

Test Coverage

Screenshots/Demos

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have created a changeset (pnpm changeset)

Changeset

  • I have created a changeset for these changes

Additional Notes

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Oct 17, 2025

@2hu12 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@haydenbleasel
Copy link
Copy Markdown
Contributor

Nice work @2hu12 - will release this soon 🙏

@haydenbleasel haydenbleasel merged commit 171a824 into vercel:main Oct 29, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base64 Image Cannot Display(1.4.0)

2 participants