fix bug with terminating lists on certain models#49
Merged
haydenbleasel merged 2 commits intomainfrom Aug 27, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
haydenbleasel
deleted the
33-bug-with-terminating-lists-on-certain-models
branch
own-boldsbrain
pushed a commit
to own-boldsbrain/streamdown
that referenced
this pull request
Sep 22, 2025
* fix asterisk list termination * Create fancy-snails-march.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the
streamdownpackage where asterisks used as list markers were incorrectly counted as formatting characters, leading to improper markdown completion. The main fix ensures that list items using asterisks are handled correctly and not terminated with an extra asterisk. Unit tests have been added to cover various list scenarios and edge cases.Bug fix for asterisk list handling
countSingleAsteriskswithinpackages/streamdown/lib/parse-incomplete-markdown.tsto detect and ignore asterisks used as list markers, preventing them from being counted as formatting characters. [1] [2]Test coverage improvements
packages/streamdown/__tests__/parse-incomplete-markdown.test.tsto verify correct handling of lists with asterisk markers, nested lists, lists with italic formatting, mixed markers, tab-indented lists, and dash lists.Documentation
.changeset/fancy-snails-march.md.