fix: do not error when not enabled during suspense #4156
Merged
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
promer94
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where SWR incorrectly threw a "Fallback data is required when using Suspense in SSR" error even when the key was disabled (falsy), which should not trigger suspense behavior.
- Moved the
hasKeyButNoDatacalculation earlier in the suspense block - Modified the SSR error condition to only throw when there's actually a key but no data
- Added comprehensive e2e tests to verify the fix works correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index/use-swr.ts | Fixed SSR error condition to only throw when key exists but data is undefined |
| e2e/test/suspense-undefined-key.test.ts | Added e2e test verifying suspense behavior with undefined keys |
| e2e/site/app/suspense-undefined-key/page.tsx | Test page demonstrating the undefined key scenario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related change in #4150, the error show not directly throw when key is falsy like disabled mode
Fixes #4155