Skip to content

fix: Sync favicon to browser theme preference on initial load#11518

Merged
anthonyshew merged 1 commit intomainfrom
shew/26860
Jan 19, 2026
Merged

fix: Sync favicon to browser theme preference on initial load#11518
anthonyshew merged 1 commit intomainfrom
shew/26860

Conversation

@anthonyshew
Copy link
Contributor

Summary

  • Fixes favicon always showing the dark variant regardless of browser theme preference on non-docs routes
  • The useColorScheme hook now syncs the initial value on mount, since SSR defaults to "light" and React preserves that state during hydration

The useEffect previously only listened for changes to prefers-color-scheme, but never set the correct value after hydration when the browser was already in dark mode.

@anthonyshew anthonyshew requested a review from a team as a code owner January 19, 2026 14:04
@vercel
Copy link
Contributor

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
examples-basic-web Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-designsystem-docs Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-gatsby-web Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-kitchensink-blog Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-nonmonorepo Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-svelte-web Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-tailwind-web Ready Ready Preview, Comment Jan 19, 2026 2:05pm
examples-vite-web Ready Ready Preview, Comment Jan 19, 2026 2:05pm
turbo-site Ready Ready Preview, Comment Jan 19, 2026 2:05pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
turborepo-test-coverage Skipped Skipped Jan 19, 2026 2:05pm

@anthonyshew anthonyshew requested a review from tknickman January 19, 2026 14:04
@turbo-orchestrator turbo-orchestrator bot added the area: site Issues and improvements related to Turborepo's documentation website label Jan 19, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 4 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

@anthonyshew anthonyshew merged commit 2b3c8bc into main Jan 19, 2026
39 checks passed
@anthonyshew anthonyshew deleted the shew/26860 branch January 19, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: site Issues and improvements related to Turborepo's documentation website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant