Skip to content

perf: Reduce allocations in file hash computation #12102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonyshew merged 1 commit into from
Mar 2, 2026
+24 −13
Merged

perf: Reduce allocations in file hash computation #12102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions crates/turborepo-scm/src/repo_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,19 +190,30 @@ impl RepoGitIndex {
let prefix_str = pkg_prefix.as_str();
let prefix_is_empty = prefix_str.is_empty();

// Compute range bounds once for both ls_tree and status lookups
let range_start;
let range_end;
if !prefix_is_empty {
range_start = format!("{}/", prefix_str);
range_end = format!("{}0", prefix_str);
} else {
range_start = String::new();
range_end = String::new();
}

let mut hashes = if prefix_is_empty {
let mut h = GitHashes::with_capacity(self.ls_tree_hashes.len());
for (path, hash) in &self.ls_tree_hashes {
h.insert(path.clone(), *hash);
}
h
} else {
let range_start = RelativeUnixPathBuf::new(format!("{}/", prefix_str)).unwrap();
let range_end = RelativeUnixPathBuf::new(format!("{}0", prefix_str)).unwrap();
let lo = self
.ls_tree_hashes
.partition_point(|(k, _)| *k < range_start);
let hi = self.ls_tree_hashes.partition_point(|(k, _)| *k < range_end);
.partition_point(|(k, _)| k.as_str() < range_start.as_str());
let hi = self
.ls_tree_hashes
.partition_point(|(k, _)| k.as_str() < range_end.as_str());
let mut h = GitHashes::with_capacity(hi - lo);
for (path, hash) in &self.ls_tree_hashes[lo..hi] {
if let Ok(stripped) = path.strip_prefix(pkg_prefix) {
Expand All @@ -216,12 +227,12 @@ impl RepoGitIndex {
let status_entries = if prefix_is_empty {
&self.status_entries[..]
} else {
let range_start = RelativeUnixPathBuf::new(format!("{}/", prefix_str)).unwrap();
let range_end = RelativeUnixPathBuf::new(format!("{}0", prefix_str)).unwrap();
let lo = self
.status_entries
.partition_point(|e| e.path < range_start);
let hi = self.status_entries.partition_point(|e| e.path < range_end);
.partition_point(|e| e.path.as_str() < range_start.as_str());
let hi = self
.status_entries
.partition_point(|e| e.path.as_str() < range_end.as_str());
&self.status_entries[lo..hi]
};
for entry in status_entries {
Expand Down
10 changes: 5 additions & 5 deletions crates/turborepo-task-hash/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ impl PackageInputsHashes {
info.inputs.globs.clone(),
info.inputs.default,
);
let idx = match key_indices.get(&key) {
Some(&idx) => idx,
None => {
let idx = match key_indices.entry(key) {
std::collections::hash_map::Entry::Occupied(e) => *e.get(),
std::collections::hash_map::Entry::Vacant(e) => {
let idx = unique_keys.len();
key_indices.insert(key.clone(), idx);
unique_keys.push(key);
unique_keys.push(e.key().clone());
e.insert(idx);
idx
}
};
Expand Down
Loading