-
Notifications
You must be signed in to change notification settings - Fork 158
Fix hasStepSourceMaps to return false for Vercel production builds #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Step sourcemaps don't work in Vercel production deployments. Previously the function returned true for most frameworks on all Vercel deployments. Now it correctly returns false for production builds while preserving the existing behavior for preview builds.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)nuxt (1 failed):
🌍 Community Worlds (17 failed)mongodb (1 failed):
redis (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where step sourcemap tests were failing in Vercel production deployments by updating the hasStepSourceMaps() function to return false when running in production environments. The change correctly differentiates between Vercel production and preview builds.
Key Changes:
- Added early return check for Vercel production environments (
WORKFLOW_VERCEL_ENV === 'production') - Updated comment to clarify that preview builds (not all Vercel builds) support step source maps for most frameworks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
hasStepSourceMaps()to returnfalsewhenWORKFLOW_VERCEL_ENV === 'production'trueexcept for sveltekit)This is a follow-up fix to PR #720 which introduced step sourcemap tests.