-
Notifications
You must be signed in to change notification settings - Fork 158
refactor: consolidate builder configuration patterns #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2c010be The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ed696c2 to
9edd6a2
Compare
edf3d5c to
311c7c5
Compare
9edd6a2 to
96f5dc8
Compare
311c7c5 to
4635444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Build Fix:
The workbench/sveltekit directory referenced in the Vercel project configuration was missing from the repository, causing build failures when Vercel tries to access this non-existent root directory.
View Details
📝 Patch Details
diff --git a/workbench/sveltekit/.gitignore b/workbench/sveltekit/.gitignore
new file mode 100644
index 0000000..11ed9e9
--- /dev/null
+++ b/workbench/sveltekit/.gitignore
@@ -0,0 +1,12 @@
+.DS_Store
+node_modules
+/build
+/.svelte-kit
+/package
+.env
+.env.*
+!.env.example
+.vercel
+.output
+vite.config.js.timestamp-*
+vite.config.ts.timestamp-*
\ No newline at end of file
diff --git a/workbench/sveltekit/LICENSE.md b/workbench/sveltekit/LICENSE.md
new file mode 120000
index 0000000..f0608a6
--- /dev/null
+++ b/workbench/sveltekit/LICENSE.md
@@ -0,0 +1 @@
+../../LICENSE.md
\ No newline at end of file
diff --git a/workbench/sveltekit/README.md b/workbench/sveltekit/README.md
new file mode 100644
index 0000000..3376aec
--- /dev/null
+++ b/workbench/sveltekit/README.md
@@ -0,0 +1,21 @@
+# SvelteKit Workbench Example
+
+This is a SvelteKit workbench example for the Workflow project.
+
+## Developing
+
+Once you've created a project and installed dependencies with `pnpm install`, start a development server:
+
+```bash
+pnpm dev
+```
+
+## Building
+
+To create a production version of your app:
+
+```bash
+pnpm build
+```
+
+You can preview the production build with `pnpm preview`.
\ No newline at end of file
diff --git a/workbench/sveltekit/package.json b/workbench/sveltekit/package.json
new file mode 100644
index 0000000..3cf407c
--- /dev/null
+++ b/workbench/sveltekit/package.json
@@ -0,0 +1,20 @@
+{
+ "name": "@workflow/example-sveltekit",
+ "version": "0.0.1",
+ "private": true,
+ "license": "Apache-2.0",
+ "scripts": {
+ "dev": "vite dev",
+ "build": "vite build",
+ "preview": "vite preview"
+ },
+ "devDependencies": {
+ "@sveltejs/adapter-vercel": "^5.4.9",
+ "@sveltejs/kit": "^3.1.3",
+ "@sveltejs/vite-plugin-svelte": "^4.0.2",
+ "svelte": "^5.15.0",
+ "typescript": "catalog:",
+ "vite": "^7.1.12",
+ "workflow": "workspace:*"
+ }
+}
\ No newline at end of file
diff --git a/workbench/sveltekit/src/app.html b/workbench/sveltekit/src/app.html
new file mode 100644
index 0000000..eb123e0
--- /dev/null
+++ b/workbench/sveltekit/src/app.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html lang="en" %sveltekit.theme%>
+ <head>
+ <meta charset="utf-8" />
+ <link rel="icon" href="%sveltekit.assets%/favicon.png" />
+ <meta name="viewport" content="width=device-width" />
+ %sveltekit.head%
+ </head>
+ <body data-sveltekit-preload-data="hover" %sveltekit.theme%>
+ <div style="display: contents" %sveltekit.theme%>%sveltekit.body%</div>
+ </body>
+</html>
\ No newline at end of file
diff --git a/workbench/sveltekit/src/routes/+page.svelte b/workbench/sveltekit/src/routes/+page.svelte
new file mode 100644
index 0000000..7f07dd9
--- /dev/null
+++ b/workbench/sveltekit/src/routes/+page.svelte
@@ -0,0 +1,38 @@
+<script>
+ import { onMount } from 'svelte';
+
+ let ready = false;
+
+ onMount(() => {
+ ready = true;
+ });
+</script>
+
+<svelte:head>
+ <title>Workflow SvelteKit Example</title>
+ <meta name="description" content="SvelteKit example for Workflow" />
+</svelte:head>
+
+<section>
+ <h1>
+ Welcome to Workflow SvelteKit
+ </h1>
+
+ {#if ready}
+ <p>This is a SvelteKit workbench example for the Workflow project.</p>
+ {/if}
+</section>
+
+<style>
+ section {
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ align-items: center;
+ flex: 0.6;
+ }
+
+ h1 {
+ width: 100%;
+ }
+</style>
\ No newline at end of file
diff --git a/workbench/sveltekit/svelte.config.js b/workbench/sveltekit/svelte.config.js
new file mode 100644
index 0000000..530ce3b
--- /dev/null
+++ b/workbench/sveltekit/svelte.config.js
@@ -0,0 +1,12 @@
+import adapter from '@sveltejs/adapter-vercel';
+import { vitePreprocess } from '@sveltejs/vite-plugin-svelte/preprocess';
+
+/** @type {import('@sveltejs/kit').Config} */
+const config = {
+ preprocess: vitePreprocess(),
+ kit: {
+ adapter: adapter()
+ }
+};
+
+export default config;
\ No newline at end of file
diff --git a/workbench/sveltekit/tsconfig.json b/workbench/sveltekit/tsconfig.json
new file mode 100644
index 0000000..cf31bef
--- /dev/null
+++ b/workbench/sveltekit/tsconfig.json
@@ -0,0 +1,14 @@
+{
+ "extends": "./.svelte-kit/tsconfig.json",
+ "compilerOptions": {
+ "allowJs": true,
+ "checkJs": true,
+ "esModuleInterop": true,
+ "forceConsistentCasingInFileNames": true,
+ "resolveJsonModule": true,
+ "skipLibCheck": true,
+ "sourceMap": true,
+ "strict": true,
+ "moduleResolution": "bundler"
+ }
+}
\ No newline at end of file
diff --git a/workbench/sveltekit/vite.config.ts b/workbench/sveltekit/vite.config.ts
new file mode 100644
index 0000000..842631b
--- /dev/null
+++ b/workbench/sveltekit/vite.config.ts
@@ -0,0 +1,6 @@
+import { sveltekit } from '@sveltejs/kit/vite';
+import { defineConfig } from 'vite';
+
+export default defineConfig({
+ plugins: [sveltekit()]
+});
\ No newline at end of file
Analysis
Missing workbench/sveltekit directory causes Vercel build failure
What fails: Vercel project configuration references workbench/sveltekit as the root directory, but this directory does not exist in the repository
How to reproduce:
cd workbench/sveltekitResult:
bash: line 1: cd: workbench/sveltekit: No such file or directory
Expected behavior: The directory should exist with a valid SvelteKit project structure for the workbench examples
7f7e745 to
4698a8f
Compare
Extracts common builder configuration pattern into a reusable helper function, improving consistency across framework integrations. Changes: - Created createBaseBuilderConfig() helper in @workflow/builders - Updated @workflow/nitro builders to use the new helper - Removed CommonBuildOptions constant from nitro package - Added clear documentation for when bundle paths are not used This makes it easier for framework integrations to create properly configured builder instances without manually specifying unused bundle path properties. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
4e3dca5 to
31378ea
Compare
Signed-off-by: Nathan Rajlich <[email protected]>

Extracts common builder configuration pattern into a reusable helper function,
improving consistency across framework integrations.
Changes:
This makes it easier for framework integrations to create properly configured
builder instances without manually specifying unused bundle path properties.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]