Conversation
unwrap_tuple is not yet supported though
Allow implicit bytesN → Bytes[M] conversion when N ≤ M
| val JE_Int_tm : term | ||
| val JE_Decimal_tm : term | ||
| val JE_Str_tm : term | ||
| val JE_GenericStr_tm : term |
Member
Author
There was a problem hiding this comment.
The Str decoder expects field "type" (field "length" numtm) — it needs type.length to be a number. But the Str node for the method_id argument has:
"type": {
"generic": "string"
}This constructor is for strings that are like that.
Contributor
There was a problem hiding this comment.
hm ok. there are other "generic" type things in builtins, not sure if they will all need to be handled in an ad hoc way
Ensure short byte sequences land in the right position for conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and do what's needed to get them to pass (or manually exclude ones we want to defer)