passes: restructure phi_elim + RTA to defs/proofs/correctness/rollup pattern#171
Open
charles-cooper wants to merge 4 commits intomainfrom
Open
passes: restructure phi_elim + RTA to defs/proofs/correctness/rollup pattern#171charles-cooper wants to merge 4 commits intomainfrom
charles-cooper wants to merge 4 commits intomainfrom
Conversation
…pattern
Matches the analysis directory structure (defs/, proofs/, Props, rollup).
phi_elimination:
- defs/: phiDefs, phiTransform, phiWellFormed, phiOrigins (was dfgOrigins)
- proofs/: phiBlock, phiCorrectnessProof (was phiFunction)
- phiElimCorrectness: ACCEPT_TAC top-level correctness theorems
- phiElim: rollup
revert_to_assert:
- defs/: rtaDefs (was rtaPassDefs)
- proofs/: rtaHelpers (was rtaProofHelpers), rtaBlockProof (was rtaPattern1),
rtaCorrectnessProof (was rtaPassCorrectness)
- rtaCorrectness: ACCEPT_TAC top-level correctness theorem
- rta: rollup
Also:
- venomPassesHol rollup theory (like venomAnalysisHol)
- RTA: removed export_theory(), modernized syntax
- Root Holmakefile simplified to just venom/passes
…nction), fix NL descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
co-authored by claude opus 4.6
Restructure
venom/passes/to match the analysis directory pattern (defs/,proofs/, correctness, rollup).Changes
Directory structure (both passes)
defs/— definitions and well-formedness predicatesproofs/— correctness proofs (block-level, helpers, lifting)*CorrectnessScript.sml— top-level correctness theorems (ACCEPT_TAC)*Script.sml— rollup (consumers just needAncestors phiElimorAncestors rta)phi_elimination renames
dfgOriginsScriptdefs/phiOriginsScriptphiFunctionScriptproofs/phiCorrectnessProofScriptphiElimCorrectnessScript(ACCEPT_TAC)phiElimScript(rollup)revert_to_assert renames
rtaPassDefsScriptdefs/rtaDefsScriptrtaPattern1Scriptproofs/rtaBlockProofScriptrtaProofHelpersScriptproofs/rtaHelpersScriptrtaPassCorrectnessScriptproofs/rtaCorrectnessProofScriptrtaCorrectnessScript(ACCEPT_TAC)rtaScript(rollup)Other
venomPassesHolScript.sml— passes rollup (likevenomAnalysisHol)export_theory(), modernized toTheory/Ancestorssyntaxvenom/passes